[Fix] 키보드 변경에 따른 UI 오류 수정 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekrud99
approved these changes
Dec 1, 2024
| @@ -32,7 +32,7 @@ public final class ChatViewController: UIViewController { | |||
| private var dataSource: UICollectionViewDiffableDataSource<CollectionViewSection, ChatMessageCellModel>? | |||
| private let viewModel: ChatViewModel | |||
| private var cancellables: Set<AnyCancellable> | |||
| private var keyboardSize: CGRect? | |||
| private var keyboardHeight: CGFloat? | |||
taipaise
approved these changes
Dec 2, 2024
choijungp
approved these changes
Dec 2, 2024
Comment on lines
+178
to
+182
| var keyboardInset: CGFloat = 0 | ||
| if let keyboardHeight { | ||
| keyboardInset = keyboardFrame.cgRectValue.height - keyboardHeight | ||
| } else { | ||
| keyboardInset = keyboardFrame.cgRectValue.height |
There was a problem hiding this comment.
Suggested change
| var keyboardInset: CGFloat = 0 | |
| if let keyboardHeight { | |
| keyboardInset = keyboardFrame.cgRectValue.height - keyboardHeight | |
| } else { | |
| keyboardInset = keyboardFrame.cgRectValue.height | |
| var keyboardInset: CGFloat = keyboardFrame.cgRectValue.height | |
| if let keyboardHeight { | |
| keyboardInset -= keyboardHeight | |
| } |
이르케 하면 else까지는 없어두 될듯요 !!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌁 Background
키보드의 유무에 따라 Layout을 변경 해주는 코드에서 키보드가 이모티콘 키보드로 변경시에도 키보드를 올렸다는 이벤트가 NotificationCenter에서 발생하는 것을 발견 해 고쳤습니다.
📱 Screenshot
수정하기 전
수정 후
👩💻 Contents
키보드에 따라 뷰 layout변경하는 부분을 수정했습니다.
✅ Testing
채팅 뷰에 들어가서 채팅을 보낼 때 키보드를 변경 해보시면 됩니다.