[Fix] 채팅 관련 QA해결 #137
Merged
[Fix] 채팅 관련 QA해결 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taipaise
approved these changes
Dec 2, 2024
| @@ -54,30 +54,27 @@ class SceneDelegate: UIResponder, UIWindowSceneDelegate { | |||
| textFieldDefaultSize: CGSize(width: 200, height: 50)) | |||
| let drawObjectUseCase = DrawObjectUseCase() | |||
| let gameObjectUseCase = GameObjectUseCase(repository: GameRepository(persistenceService: PersistenceService())) | |||
| let addPhotoUseCase = PhotoUseCase(photoRepository: photoRepository) | |||
| let photoUseCase = PhotoUseCase(photoRepository: photoRepository) | |||
There was a problem hiding this comment.
하 이런 디테일 놓친거까지 챙겨주다니.. 그저 갓
| textObjectUseCase: textObjectUseCase, | ||
| chatUseCase: chatUseCase, | ||
| gameObjectUseCase: gameObjectUseCase, | ||
| manageWhiteboardToolUseCase: manageWhiteboardToolUseCase, |
There was a problem hiding this comment.
ㅋㅋ리팩토링 하면서 주입관련해서 같이 고민 해봅시다!!
choijungp
approved these changes
Dec 2, 2024
| gameObjectUseCase: GameObjectUseCaseInterface, | ||
| managemanageWhiteboardToolUseCase: ManageWhiteboardToolUseCaseInterface, | ||
| manageWhiteboardToolUseCase: ManageWhiteboardToolUseCaseInterface, |
There was a problem hiding this comment.
ㅋㅋㅋㅋㅋㅋ managemange 이번에는 확실히 죽인걸루 ~~
ekrud99
approved these changes
Dec 2, 2024
| chatUseCase: ChatUseCaseInterface, | ||
| gameObjectUseCase: GameObjectUseCaseInterface, | ||
| manageWhiteboardToolUseCase: ManageWhiteboardToolUseCaseInterface, | ||
| manageWhiteboardObjectUseCase: ManageWhiteboardObjectUseCaseInterface |
There was a problem hiding this comment.
민족 대이동을 하셨군요..
고생하셨습니다.. 😭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌁 Background
QA에서 나온 채팅관련 이슈들을 해결하고 변경 해 주었습니다.
📱 Screenshot
👩💻 Contents
📝 Review Note
현재 ViewModel을 생성하는 시점을 변경 해 주었습니다.
이 과정에서 뷰컨트롤러를 통해 필요한 usecase를 전달해 주는데요, 의존성을 낮추기 위해서 계층을 분리하고 인터페이스를 만들었는데 해당 과정 때문에 의존성 관리가 제대로 되고 있는지가 의문입니다..!