Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

책 읽기 뷰에서 이미지 불러오기 #123

Merged
merged 20 commits into from
Dec 2, 2024

Conversation

k2645
Copy link
Collaborator

@k2645 k2645 commented Dec 2, 2024

#️⃣ 연관된 이슈


⏰ 작업 시간

예상 시간 실제 걸린 시간
3 5

📝 작업 내용

  • 책 읽기 뷰에서 이미지에 대한 정보 불러오기
  • BookCover 클릭시 뷰가 여러번 보여지는 버그 수정

📸 스크린샷

ScreenRecording_12-03-2024.03-17-38_1.MP4

@k2645 k2645 added ✨ Feature 기능 관련 작업 🛠️ Fix 오류, 버그 수정 labels Dec 2, 2024
@k2645 k2645 added this to the 0.4 milestone Dec 2, 2024
@k2645 k2645 self-assigned this Dec 2, 2024
@k2645 k2645 linked an issue Dec 2, 2024 that may be closed by this pull request
Copy link
Collaborator

@yuncheol-AHN yuncheol-AHN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구뜨
너무너무 고생하셨습니다 !!!

Comment on lines +80 to +83
required init?(coder: NSCoder) {
fatalError("init(coder:) has not been implemented")
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3
fatalError 제거해주시면 좋을 거 같아요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아ㅏ 해당 부분은 다음 PR에서 ViewModel 수정하면서 같이 바꿀 예정입니다 ! 위에 TODO 추가해뒀습니당

@k2645 k2645 merged commit 9f1534a into develop Dec 2, 2024
2 checks passed
@k2645 k2645 deleted the feature/load-multi-media-in-page branch December 2, 2024 18:49
Copy link
Member

@Kyxxn Kyxxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 〰️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 관련 작업 🛠️ Fix 오류, 버그 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

멀티미디어 불러오기
3 participants