Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] - AI Modal UI 구현 #22

Merged
merged 7 commits into from
Feb 6, 2025
Merged

[FE] - AI Modal UI 구현 #22

merged 7 commits into from
Feb 6, 2025

Conversation

chan-byeong
Copy link
Collaborator

#️⃣연관된 이슈

📝작업 내용

  • 유저가 프롬프트를 입력할 수 있는 모달을 구현했습니다.

스크린샷

image

💬리뷰 요구사항

Modal 컴포넌트를 수정해야될 것 같습니다.

현재는 모달을 쓰는 컴포넌트에서 모달을 열고 닫는 상태값을 가지고 있는데 이러한 상태를 모달이 갖게하는 것이 더 좋아보입니다.

도훈님이 전에 올려두었던 글을 참고해서 수정하겠습니다.

https://www.developerway.com/posts/hard-react-questions-and-modal-dialog

참고 자료

@chan-byeong chan-byeong added the ✨ Feature 기능 작업 label Feb 5, 2025
@chan-byeong chan-byeong self-assigned this Feb 5, 2025
Comment on lines 41 to 46
<button
type="submit"
className="w-full py-3 px-4 bg-blue-600 text-white rounded-lg hover:bg-blue-700 transition-colors duration-200 font-medium flex items-center justify-center space-x-2"
>
<span>퀴즈 생성하기</span>
</button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 mutate 추가할 때 disabledisLoading 값을 추가하면 좋을 것 같습니다!
(저번에 이야기했던 따닥 방지에 효과적일 것 같습니다!)

Comment on lines 45 to 48
<Modal onClose={() => setAiModal(false)}>
<AiQuizModal />
</Modal>
)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dooohun dooohun merged commit 18f4af4 into develop Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants