-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] - AI Modal UI 구현 #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dooohun
approved these changes
Feb 6, 2025
Comment on lines
41
to
46
<button | ||
type="submit" | ||
className="w-full py-3 px-4 bg-blue-600 text-white rounded-lg hover:bg-blue-700 transition-colors duration-200 font-medium flex items-center justify-center space-x-2" | ||
> | ||
<span>퀴즈 생성하기</span> | ||
</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나중에 mutate
추가할 때 disabled
에 isLoading
값을 추가하면 좋을 것 같습니다!
(저번에 이야기했던 따닥 방지에 효과적일 것 같습니다!)
Comment on lines
45
to
48
<Modal onClose={() => setAiModal(false)}> | ||
<AiQuizModal /> | ||
</Modal> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
스크린샷
💬리뷰 요구사항
Modal 컴포넌트를 수정해야될 것 같습니다.
현재는 모달을 쓰는 컴포넌트에서 모달을 열고 닫는 상태값을 가지고 있는데 이러한 상태를 모달이 갖게하는 것이 더 좋아보입니다.
도훈님이 전에 올려두었던 글을 참고해서 수정하겠습니다.
https://www.developerway.com/posts/hard-react-questions-and-modal-dialog
참고 자료