🧼 clean: 코드 일관성 향상

feed-crawler/src/repository/feed.repository.ts

@@ -34,16 +34,16 @@ export class FeedRepository {
     const promiseResults = await Promise.all(insertPromises);
 
     const insertedFeeds = promiseResults
-      .map((result: any, index) => {
-        if (result) {
-          const insertId = result.insertId;
+      .map((feed: any, index) => {
+        if (feed) {
+          const insertId = feed.insertId;
           return {
             ...resultData[index],
             id: insertId,
           };
         }
       })
-      .filter((result) => result);
+      .filter((feed) => feed);
 
     logger.info(
       `[MySQL] ${insertedFeeds.length}개의 피드 데이터가 성공적으로 데이터베이스에 삽입되었습니다.`,

server/src/admin/controller/admin.controller.ts

@@ -72,7 +72,6 @@ export class AdminController {
   @Get('/sessionId')
   @HttpCode(HttpStatus.OK)
   @UseGuards(CookieAuthGuard)
-  @UsePipes(new ValidationPipe({ transform: true }))
   async readSessionIdAdmin() {
     return ApiResponse.responseWithNoContent('정상적인 sessionId 입니다.');
   }

server/src/admin/dto/request/login-admin.dto.ts

@@ -3,7 +3,7 @@ import { ApiProperty } from '@nestjs/swagger';
 
 export class LoginAdminRequestDto {
   @ApiProperty({
-    example: 'minseokjo',
+    example: 'test',
     description: '관리자 로그인 아이디를 입력해주세요.',
   })
   @IsNotEmpty({
@@ -15,7 +15,7 @@ export class LoginAdminRequestDto {
   loginId: string;
 
   @ApiProperty({
-    example: 'heisgoat123!',
+    example: 'test1234!',
     description: '패스워드를 입력해주세요.',
   })
   @IsNotEmpty({

server/src/admin/dto/request/register-admin.dto.ts

@@ -5,7 +5,7 @@ const PASSWORD_REG = /^(?=.*[!@#$%^&*()_+])[A-Za-z0-9!@#$%^&*()_+]+$/;
 
 export class RegisterAdminRequestDto {
   @ApiProperty({
-    example: 'minseokjo',
+    example: 'test',
     description: '관리자 로그인 아이디를 입력해주세요.',
   })
   @IsString({
@@ -17,7 +17,7 @@ export class RegisterAdminRequestDto {
   loginId: string;
 
   @ApiProperty({
-    example: 'heisgoat123!',
+    example: 'test1234!',
     description:
       '패스워드를 입력해주세요. (최소 6자, 영문/숫자/특수문자로 이루어질 수 있으며 특수문자 1개 이상 포함)',
   })

server/src/feed/api-docs/searchFeedList.api-docs.ts

@@ -17,7 +17,7 @@ export function ApiSearchFeedList() {
       required: true,
       type: String,
       description: '검색어',
-      example: '데나무',
+      example: 'test',
     }),
     ApiQuery({
       name: 'type',
@@ -96,7 +96,7 @@ export function ApiSearchFeedList() {
             {
               id: 1,
               blogName: '블로그 이름',
-              title: '데나무',
+              title: 'test',
               path: 'https://test.com/1',
               createdAt: '2024-10-27T02:08:55.000Z',
             },

server/src/feed/api-docs/updateFeedViewCount.api-docs.ts

@@ -3,21 +3,13 @@ import {
   ApiNotFoundResponse,
   ApiOkResponse,
   ApiOperation,
-  ApiParam,
 } from '@nestjs/swagger';
 
 export function ApiUpdateFeedViewCount() {
   return applyDecorators(
     ApiOperation({
       summary: `피드 조회수 업데이트 API`,
     }),
-    ApiParam({
-      name: 'feedId',
-      required: true,
-      type: Number,
-      description: '클릭한 피드의 id',
-      example: 1,
-    }),
     ApiOkResponse({
       description: 'Ok',
       schema: {

server/src/feed/controller/feed.controller.ts

@@ -26,6 +26,7 @@ import { ApiSearchFeedList } from '../api-docs/searchFeedList.api-docs';
 import { ApiUpdateFeedViewCount } from '../api-docs/updateFeedViewCount.api-docs';
 import { ApiReadRecentFeedList } from '../api-docs/readRecentFeedList.api-docs';
 import { FeedTrendResponseDto } from '../dto/response/feed-pagination.dto';
+import { FeedViewUpdateRequestDto } from '../dto/request/feed-update.dto';
 
 @ApiTags('Feed')
 @Controller('feed')
@@ -38,11 +39,7 @@ export class FeedController {
   @ApiReadFeedPagination()
   @Get('')
   @HttpCode(HttpStatus.OK)
-  @UsePipes(
-    new ValidationPipe({
-      transform: true,
-    }),
-  )
+  @UsePipes(new ValidationPipe({ transform: true }))
   async readFeedPagination(@Query() queryFeedDto: FeedPaginationRequestDto) {
     return ApiResponse.responseWithData(
       '피드 조회 완료',
@@ -81,27 +78,28 @@ export class FeedController {
   @ApiSearchFeedList()
   @Get('search')
   @HttpCode(HttpStatus.OK)
-  @UsePipes(
-    new ValidationPipe({
-      transform: true,
-    }),
-    new ValidationPipe(),
-  )
+  @UsePipes(new ValidationPipe({ transform: true }))
   async searchFeedList(@Query() searchFeedReq: SearchFeedRequestDto) {
-    const data = await this.feedService.searchFeedList(searchFeedReq);
-    return ApiResponse.responseWithData('검색 결과 조회 완료', data);
+    return ApiResponse.responseWithData(
+      '검색 결과 조회 완료',
+      await this.feedService.searchFeedList(searchFeedReq),
+    );
   }
 
   @ApiUpdateFeedViewCount()
   @Post('/:feedId')
   @HttpCode(HttpStatus.OK)
   @UsePipes(new ValidationPipe({ transform: true }))
   async updateFeedViewCount(
-    @Param('feedId') feedId: number,
+    @Param() params: FeedViewUpdateRequestDto,
     @Req() request: Request,
     @Res({ passthrough: true }) response: Response,
   ) {
-    await this.feedService.updateFeedViewCount(feedId, request, response);
+    await this.feedService.updateFeedViewCount(
+      params.feedId,
+      request,
+      response,
+    );
     return ApiResponse.responseWithNoContent(
       '요청이 성공적으로 처리되었습니다.',
     );

server/src/feed/dto/request/feed-update.dto.ts

@@ -0,0 +1,15 @@
+import { ApiProperty } from '@nestjs/swagger';
+import { Type } from 'class-transformer';
+import { IsInt } from 'class-validator';
+
+export class FeedViewUpdateRequestDto {
+  @ApiProperty({
+    example: 1,
+    description: '조회할 ID 입력',
+  })
+  @IsInt({
+    message: '정수를 입력해주세요.',
+  })
+  @Type(() => Number)
+  feedId: number;
+}

server/src/feed/dto/response/feed-pagination.dto.ts

@@ -39,8 +39,12 @@ export class FeedPaginationResponseDto {
     private hasMore: boolean,
   ) {}
 
-  static toResponseDto(result: FeedResult[], lastId: number, hasMore: boolean) {
-    return new FeedPaginationResponseDto(result, lastId, hasMore);
+  static toResponseDto(
+    feedPagination: FeedResult[],
+    lastId: number,
+    hasMore: boolean,
+  ) {
+    return new FeedPaginationResponseDto(feedPagination, lastId, hasMore);
   }
 }
 

server/src/feed/service/feed.service.ts

@@ -46,8 +46,12 @@ export class FeedService {
     if (hasMore) feedList.pop();
     const lastId = this.getLastIdFromFeedList(feedList);
     const newCheckFeedList = await this.checkNewFeeds(feedList);
-    const result = FeedResult.toResultDtoArray(newCheckFeedList);
-    return FeedPaginationResponseDto.toResponseDto(result, lastId, hasMore);
+    const feedPagination = FeedResult.toResultDtoArray(newCheckFeedList);
+    return FeedPaginationResponseDto.toResponseDto(
+      feedPagination,
+      lastId,
+      hasMore,
+    );
   }
 
   private existNextFeed(feedList: FeedView[], limit: number) {
@@ -62,8 +66,8 @@ export class FeedService {
     const newFeedIds = (
       await this.redisService.keys(redisKeys.FEED_RECENT_ALL_KEY)
     ).map((key) => {
-      const id = key.match(/feed:recent:(\d+)/);
-      return parseInt(id[1]);
+      const feedId = key.match(/feed:recent:(\d+)/);
+      return parseInt(feedId[1]);
     });
 
     return feedList.map((feed): FeedPaginationResult => {
@@ -98,14 +102,14 @@ export class FeedService {
       throw new BadRequestException('검색 타입이 잘못되었습니다.');
     }
 
-    const [result, totalCount] = await this.feedRepository.searchFeedList(
+    const [searchResult, totalCount] = await this.feedRepository.searchFeedList(
       find,
       limit,
       type,
       offset,
     );
 
-    const feeds = SearchFeedResult.toResultDtoArray(result);
+    const feeds = SearchFeedResult.toResultDtoArray(searchResult);
     const totalPages = Math.ceil(totalCount / limit);
 
     return SearchFeedResponseDto.toResponseDto(
@@ -195,13 +199,13 @@ export class FeedService {
       return [];
     }
 
-    const result = await this.redisService.executePipeline((pipeline) => {
+    const recentFeeds = await this.redisService.executePipeline((pipeline) => {
       for (const key of recentKeys) {
         pipeline.hgetall(key);
       }
     });
 
-    let recentFeedList: FeedRecentRedis[] = result.map(
+    let recentFeedList: FeedRecentRedis[] = recentFeeds.map(
       ([, feed]: [any, FeedRecentRedis]) => {
         return { ...feed, isNew: true };
       },

server/src/rss/controller/rss.controller.ts

@@ -4,7 +4,6 @@ import {
   Get,
   HttpCode,
   Param,
-  ParseIntPipe,
   Post,
   UsePipes,
   ValidationPipe,
@@ -53,8 +52,7 @@ export class RssController {
   @Post('accept/:id')
   @HttpCode(201)
   async acceptRss(@Param() params: RssManagementRequestDto) {
-    const { id } = params;
-    await this.rssService.acceptRss(id);
+    await this.rssService.acceptRss(params.id);
     return ApiResponse.responseWithNoContent('승인이 완료되었습니다.');
   }
 
@@ -67,8 +65,7 @@ export class RssController {
     @Body() body: RejectRssRequestDto,
     @Param() params: RssManagementRequestDto,
   ) {
-    const { id } = params;
-    await this.rssService.rejectRss(id, body.description);
+    await this.rssService.rejectRss(params.id, body.description);
     return ApiResponse.responseWithNoContent('거절이 완료되었습니다.');
   }
 

server/src/rss/dto/request/rss-register.dto.ts

@@ -16,7 +16,7 @@ export class RssRegisterRequestDto {
   blog: string;
 
   @ApiProperty({
-    example: 'J235_조민석',
+    example: 'test',
     description: '실명을 입력해주세요.',
   })
   @Length(2, 50, { message: '이름 길이가 올바르지 않습니다.' })
@@ -29,7 +29,7 @@ export class RssRegisterRequestDto {
   name: string;
 
   @ApiProperty({
-    example: 'seok3765@naver.com',
+    example: 'test@test.com',
     description: '이메일을 입력해주세요.',
   })
   @IsEmail(
@@ -44,7 +44,7 @@ export class RssRegisterRequestDto {
   email: string;
 
   @ApiProperty({
-    example: 'https://v2.velog.io/rss/@seok3765',
+    example: 'https://test.com/rss',
     description: 'RSS 주소를 입력해주세요.',
   })
   @IsUrl(

server/src/rss/service/rss.service.ts

@@ -69,20 +69,20 @@ export class RssService {
 
     const blogPlatform = this.identifyPlatformFromRssUrl(rss.rssUrl);
 
-    const [newRssAccept, feeds] = await this.dataSource.transaction(
+    const [rssAccept, feeds] = await this.dataSource.transaction(
       async (manager) => {
-        const [newRssAccept] = await Promise.all([
+        const [rssAccept] = await Promise.all([
           manager.save(RssAccept.fromRss(rss, blogPlatform)),
           manager.delete(Rss, id),
         ]);
         const feeds = await this.feedCrawlerService.loadRssFeeds(
-          newRssAccept.rssUrl,
+          rssAccept.rssUrl,
         );
-        return [newRssAccept, feeds];
+        return [rssAccept, feeds];
       },
     );
-    await this.feedCrawlerService.saveRssFeeds(feeds, newRssAccept);
-    this.emailService.sendMail(newRssAccept, true);
+    await this.feedCrawlerService.saveRssFeeds(feeds, rssAccept);
+    this.emailService.sendMail(rssAccept, true);
   }
 
   async rejectRss(id: number, description: string) {
@@ -94,17 +94,17 @@ export class RssService {
       throw new NotFoundException('존재하지 않는 rss 입니다.');
     }
 
-    const result = await this.dataSource.transaction(async (manager) => {
-      const [transactionResult] = await Promise.all([
+    const rejectRss = await this.dataSource.transaction(async (manager) => {
+      const [rejectRss] = await Promise.all([
         manager.remove(rss),
         manager.save(RssReject, {
           ...rss,
           description,
         }),
       ]);
-      return transactionResult;
+      return rejectRss;
     });
-    this.emailService.sendMail(result, false, description);
+    this.emailService.sendMail(rejectRss, false, description);
   }
 
   async readAcceptHistory() {