Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor: sonarQube에 나온 이슈 해결 #12

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

jungmyunggi
Copy link
Collaborator

🔨 테스크

SonarQube에 나온 이슈 해결

📋 작업 내용

  • 초기 104개가 있던 이슈를 34개 까지 줄임
  • 남아있는 이슈들은 map함수에서 배열 index의 사용이나 modal컴포넌트의 div에 달린 onClick이벤트 때문입니다
  • 실패가 뜬 이유는 테스트 커버리지를 80%로 잡았는데 현재 0%가 나와서 실패한것입니다

📷 스크린 샷

image

image

@jungmyunggi jungmyunggi added the 🔨 Refactor 리팩토링 (구조 변경) label Jan 13, 2025
@jungmyunggi jungmyunggi requested a review from junyeokk January 13, 2025 07:35
@jungmyunggi jungmyunggi self-assigned this Jan 13, 2025
Copy link
Collaborator

@junyeokk junyeokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다 !

client/src/components/chart/PieChartItem.tsx Show resolved Hide resolved
client/src/components/chat/layout/ChatFooter.tsx Outdated Show resolved Hide resolved
client/src/components/chat/layout/ChatSection.tsx Outdated Show resolved Hide resolved
@jungmyunggi jungmyunggi merged commit 0e36b52 into main Jan 14, 2025
1 check passed
@jungmyunggi jungmyunggi deleted the refactor/code-refactor branch January 14, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Refactor 리팩토링 (구조 변경)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants