Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor: 소소한 코드정리 #7

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

jungmyunggi
Copy link
Collaborator

🔨 테스크

gitignore에 scannerwork 추가

  • sonarqube를 사용하면서 커밋에 필요없는 파일이 추가되어서 넣었습니다.

대소문자, 상수처리

  • 타입에 들어갈 boolean을 Boolean으로 적은 코드가 있었고
  • 반복문에 const of가 아니라 let of를 사용한 코드가 있어서 수정했습니다.

📋 작업 내용

  • 소소한 코드정리

@jungmyunggi jungmyunggi added the 🔨 Refactor 리팩토링 (구조 변경) label Jan 8, 2025
@jungmyunggi jungmyunggi requested a review from junyeokk January 8, 2025 12:36
@jungmyunggi jungmyunggi self-assigned this Jan 8, 2025
@jungmyunggi jungmyunggi changed the title ♻️ refactor: 대소문자, if문 수정 ♻️ refactor: 소소한 코드정리 Jan 8, 2025
Copy link
Collaborator

@junyeokk junyeokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@jungmyunggi jungmyunggi merged commit 054c352 into main Jan 9, 2025
1 check passed
@jungmyunggi jungmyunggi deleted the refactor/correct-code-error branch January 9, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Refactor 리팩토링 (구조 변경)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants