Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Refactor HelpModal #17

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

refactor: Refactor HelpModal #17

wants to merge 9 commits into from

Conversation

dbjoung
Copy link
Collaborator

@dbjoung dbjoung commented Jan 20, 2025 •
edited
Loading

πŸ“‚ μž‘μ—… λ‚΄μš©

closes #10

  • Lottie μ• λ‹ˆλ©”μ΄μ…˜ μž¬μƒ 라이브러리 'dotlottie-react' 둜 톡일
  • .lottie νŒŒμΌλ“€ 동적 import 둜 λ³€κ²½
  • setTimeout μ‚­μ œ
  • μ‚¬μš© μ•ˆν•˜λŠ” νŒŒμΌλ“€ μ‚­μ œ

πŸ’‘ μžμ„Έν•œ μ„€λͺ…

  • Lottie μ• λ‹ˆλ©”μ΄μ…˜ μž¬μƒ 라이브러리 'dotlottie-react' 둜 톡일
    • react-lottie-player 라이브러리 μ‚­μ œ
    • μ• λ‹ˆλ©”μ΄μ…˜ 파일 .lottie둜 톡일
  • .lottie νŒŒμΌλ“€ 동적 import 둜 λ³€κ²½
    • μ΅œμƒλ‹¨μ— μ •μ μœΌλ‘œ import ν•˜κ³  있던 μ• λ‹ˆλ©”μ΄μ…˜ νŒŒμΌλ“€μ„ ν•„μš”ν•œ μ‹œμ μ— λ‘œλ”©ν•˜λŠ” 동적 import둜 λ³€κ²½
    • λͺ¨λ‹¬μ΄ 열릴 λ•Œ, νŽ˜μ΄μ§€κ°€ λ„˜μ–΄κ°ˆ λ•Œ, λͺ¨λ‹¬μ΄ λ‹«νž λ•Œ λ“± μ• λ‹ˆλ©”μ΄μ…˜ 컨트둀이 ν•„μš”ν•œ μ‹œμ μ— .play(), .stop() λ©”μ†Œλ“œ μ‚¬μš©
  • setTimeout μ‚­μ œ
    • setTimeout으둜 μ• λ‹ˆλ©”μ΄μ…˜ λ©ˆμΆ”λ˜ λ‘œμ§μ„ μ‚­μ œν•˜κ³  DotLottieReact 객체의 dotLottieRefCallback μ†μ„±μœΌλ‘œ μž¬μƒ 컨트둀
  • μ‚¬μš© μ•ˆν•˜λŠ” νŒŒμΌλ“€ μ‚­μ œ
    • game-win.lottie μ‚­μ œ
    • canvas ν΄λ”μ˜ testμš©μ΄μ—ˆλ˜ νŒŒμΌλ“€ μ‚¬μš©

πŸ“— μ°Έκ³  자료 & κ΅¬ν˜„ κ²°κ³Ό (선택)

  • HelpLollingModal λ²ˆλ“€ μ‚¬μ΄μ¦ˆ : 375.59 KB β†’ 15.33

  • μ• λ‹ˆλ©”μ΄μ…˜ μž¬μ‚¬μš© μ‹œ μš”μ²­ 파일 크기와 μ‹œκ°„ : 1.5 ~ 1.9 KB / 3~8ms β†’ 0byte / 1 ~ 7ms

  • κ°œλ°œμžλ„κ΅¬ νƒ€μž„λΌμΈ 졜μž₯ μž‘μ—… μ‹œκ°„ : 107.32ms β†’ 6.05ms

  • μžμ„Έν•œ λ‚΄μš© : κ΄€λ ¨ 기술 둜그

πŸ“’ 리뷰 μš”κ΅¬ 사항 (선택)

🚩 후속 μž‘μ—… (선택)

βœ… μ…€ν”„ 체크리슀트

  • PR 제λͺ©μ„ ν˜•μ‹μ— 맞게 μž‘μ„±ν–ˆλ‚˜μš”?
  • 브랜치 μ „λž΅μ— λ§žλŠ” λΈŒλžœμΉ˜μ— PR을 올리고 μžˆλ‚˜μš”? (main이 μ•„λ‹™λ‹ˆλ‹€.)
  • μ΄μŠˆλŠ” close ν–ˆλ‚˜μš”?
  • Reviewers, Labelsλ₯Ό λ“±λ‘ν–ˆλ‚˜μš”?
  • μž‘μ—… 도쀑 λ¬Έμ„œ μˆ˜μ •μ΄ ν•„μš”ν•œ 경우 잘 μˆ˜μ •ν–ˆλ‚˜μš”?
  • ν…ŒμŠ€νŠΈλŠ” 잘 ν†΅κ³Όν–ˆλ‚˜μš”?
  • λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ œκ±°ν–ˆλ‚˜μš”?

@dbjoung dbjoung linked an issue Jan 20, 2025 that may be closed by this pull request
도움말 νŽ˜μ΄μ§€ λ¦¬νŒ©ν† λ§ #10
Open
@github-actions GitHub Actions
Copy link

πŸ“š Storybook preview deployed to: Visit Storybook Preview

@dbjoung dbjoung added πŸ’» FE Frontend Code πŸ”¨ Refactor Code Refactoring labels Jan 20, 2025
@dbjoung dbjoung self-assigned this Jan 20, 2025
@dbjoung dbjoung requested a review from rhino-ty January 20, 2025 12:17
@dbjoung dbjoung added the πŸ“ˆ Improvement Performance Optimization label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choiseona choiseona Awaiting requested review from choiseona

@kwaksj329 kwaksj329 Awaiting requested review from kwaksj329

@ssum1ra ssum1ra Awaiting requested review from ssum1ra

@rhino-ty rhino-ty Awaiting requested review from rhino-ty

At least 2 approving reviews are required to merge this pull request.

Assignees

@dbjoung dbjoung

Labels
πŸ’» FE Frontend Code πŸ“ˆ Improvement Performance Optimization πŸ”¨ Refactor Code Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

도움말 νŽ˜μ΄μ§€ λ¦¬νŒ©ν† λ§
1 participant
@dbjoung