docker .env bind mount 제거 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ezcolin2
added
🐧🚀😶🌫️ BE
ezcolin2
force-pushed
the
refactor-be-#45
branch
3 times, most recently
from
b92783b to
250deaf
Compare
summersummerwhy
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔖 연관된 이슈
📂 작업 내용
저번 피어세션 시간에 보안을 위해 .env 파일을 bind mount했다고 발표를 하니 한 분께서 docker-compose에서 제공해주는 env_file을 사용하면 bind mount 없이도 쉽게 환경 변수를 주입할 수 있다고 하셔서 적용해보았습니다.
bind mount 자체를 없앨 수 있어서 좋은 것 같습니다.
그리고 AuthController test에 JwtAuthGuard 주입 추가했고 현준님 자동 리뷰어로 등록되는 현상 있어서 현준님 리뷰어 그룹에서 제거했습니다.
📑 참고 자료
https://docs.docker.com/compose/how-tos/environment-variables/set-environment-variables/