[BE] 6.02 각 주식 정보 가져오기 API 구현 #54 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sieunie
approved these changes
Nov 14, 2024
| import { BaseEntity, Column, Entity, PrimaryColumn } from 'typeorm'; | ||
|
|
||
| @Entity() | ||
| export class Stocks extends BaseEntity { |
There was a problem hiding this comment.
🟢 앗 이거도 저희 컨벤션 맞춰야겠네요...! 저는 클래스 이름은 Stock 이런식으로 하구 @Entity('stocks') 이렇게 옵션 추가해서 올렸었거든요
그리고 저희 BaseEntity는 쓰는걸로 결정났었나요??
There was a problem hiding this comment.
아 아뇨, BaseEntity 쓰는 거로 결정은 안났고.. 제가 필요한 코드랑 진명님이 작성하신 코드(stock-list 엔티티와 레포지토리 부분)랑 완전 똑같아서 여쭤보니까 상위 폴더에 만들어서 같이 쓰는게 낫겠다는 결론이 나왔어요. 그래서 나중에 합치기 쉽게 복사붙여넣기 해서 가져왔어요..ㅎㅎ
클래스 이름이랑 BaseEntity 사용 여부와 같은 경우에는 이야기 나눠봐야겠네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 주요 작업
💭 고민과 해결과정