[BE] 6.02 각 주식 정보 가져오기 API 구현 #54 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sieunie
approved these changes
Nov 13, 2024
sieunie
reviewed
Nov 13, 2024
Comment on lines
+160
to
+166
| private async requestApi<T>( | ||
| trId: string, | ||
| apiURL: string, | ||
| params: Record<string, string>, | ||
| ): Promise<T> { | ||
| try { | ||
| const accessToken = await this.koreaInvetmentService.getAccessToken(); |
There was a problem hiding this comment.
🟢 아니면... 이 메소드를 koreaInvestmentService에 위치시키면 전역에서 쓰도록 할 수 있지 않을까요??
There was a problem hiding this comment.
그렇게 하면 여전히 다른 서비스 계층들이 koreaInvestmentService를 참조해야 하지 않나요..?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 주요 작업
💭 고민과 해결과정