Feature/#304 - ts-mockito 적용 (#307)

boostcampwm-2024 · Dec 1, 2024 · 7a8636d · 7a8636d
2 parents 3c20f94 + 683096e
commit 7a8636d
Show file tree

Hide file tree

Showing 8 changed files with 240 additions and 361 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -69,4 +69,12 @@ module.exports = {
       },
     ],
   },
+  overrides: [
+    {
+      files: ['**/*.spec.ts'],
+      rules: {
+        'max-lines-per-function': 'off',
+      },
+    },
+  ],
 };
diff --git a/packages/backend/package.json b/packages/backend/package.json
@@ -74,6 +74,7 @@
     "supertest": "^7.0.0",
     "ts-jest": "^29.1.0",
     "ts-loader": "^9.4.3",
+    "ts-mockito": "^2.6.1",
     "ts-node": "^10.9.1",
     "tsconfig-paths": "^4.2.0",
     "typescript": "^5.1.3"

diff --git a/packages/backend/src/chat/like.service.spec.ts b/packages/backend/src/chat/like.service.spec.ts
@@ -1,18 +1,19 @@
-import { DataSource } from 'typeorm';
+import { anything, instance, mock, when } from 'ts-mockito';
+import { DataSource, EntityManager } from 'typeorm';
 import { Chat } from '@/chat/domain/chat.entity';
 import { Like } from '@/chat/domain/like.entity';
 import { LikeService } from '@/chat/like.service';
 import { Stock } from '@/stock/domain/stock.entity';
 import { User } from '@/user/domain/user.entity';
-import { createDataSourceMock } from '@/user/user.service.spec';
 
 function createChat(): Chat {
   return {
-    stock: new Stock(),
+    stock: { id: '005930', name: '삼성전자' } as Stock,
     user: new User(),
     id: 1,
     likeCount: 1,
     message: '안녕하세요',
+    mentions: [],
     type: 'NORMAL',
     date: {
       createdAt: new Date(),
@@ -22,27 +23,36 @@ function createChat(): Chat {
 }
 
 describe('LikeService 테스트', () => {
-  test('존재하지 않는 채팅을 좋아요를 시도하면 예외가 발생한다.', () => {
-    const managerMock = {
-      findOne: jest.fn().mockResolvedValue(null),
-    };
-    const datasource = createDataSourceMock(managerMock);
-    const likeService = new LikeService(datasource as DataSource);
+  let likeService: LikeService;
+  let datasourceMock: DataSource;
+  let managerMock: EntityManager;
 
-    expect(likeService.toggleLike(1, 1)).rejects.toThrow('Chat not found');
+  test('존재하지 않는 채팅을 좋아요를 시도하면 예외가 발생한다.', async () => {
+    datasourceMock = mock(DataSource);
+    managerMock = mock(EntityManager);
+    when(managerMock.findOne(Chat, anything())).thenResolve(null);
+    when(datasourceMock.transaction(anything())).thenCall(async (callback) => {
+      return await callback(instance(managerMock));
+    });
+
+    likeService = new LikeService(instance(datasourceMock));
+
+    await expect(() => likeService.toggleLike(1, 1)).rejects.toThrow(
+      'Chat not found',
+    );
   });
 
   test('특정 채팅에 좋아요를 한다.', async () => {
     const chat = createChat();
-    const managerMock = {
-      findOne: jest
-        .fn()
-        .mockResolvedValueOnce(chat)
-        .mockResolvedValueOnce(null),
-      save: jest.fn(),
-    };
-    const datasource = createDataSourceMock(managerMock);
-    const likeService = new LikeService(datasource as DataSource);
+    datasourceMock = mock(DataSource);
+    managerMock = mock(EntityManager);
+    when(managerMock.findOne(Chat, anything()))
+      .thenResolve(chat)
+      .thenResolve(null);
+    when(datasourceMock.transaction(anything())).thenCall(async (callback) => {
+      return await callback(instance(managerMock));
+    });
+    likeService = new LikeService(instance(datasourceMock));
 
     const response = await likeService.toggleLike(1, 1);
 
@@ -51,15 +61,14 @@ describe('LikeService 테스트', () => {
 
   test('특정 채팅에 좋아요를 취소한다.', async () => {
     const chat = createChat();
-    const managerMock = {
-      findOne: jest
-        .fn()
-        .mockResolvedValueOnce(chat)
-        .mockResolvedValueOnce(new Like()),
-      remove: jest.fn(),
-    };
-    const datasource = createDataSourceMock(managerMock);
-    const likeService = new LikeService(datasource as DataSource);
+    datasourceMock = mock(DataSource);
+    managerMock = mock(EntityManager);
+    when(managerMock.findOne(Chat, anything())).thenResolve(chat);
+    when(managerMock.findOne(Like, anything())).thenResolve(new Like());
+    when(datasourceMock.transaction(anything())).thenCall(async (callback) => {
+      return await callback(instance(managerMock));
+    });
+    likeService = new LikeService(instance(datasourceMock));
 
     const response = await likeService.toggleLike(1, 1);
 

diff --git a/packages/backend/src/scraper/korea-stock-info/korea-stock-info.service.spec.ts b/packages/backend/src/scraper/korea-stock-info/korea-stock-info.service.spec.ts
@@ -1,11 +1,20 @@
 import { Test, TestingModule } from '@nestjs/testing';
 import { KoreaStockInfoService } from './korea-stock-info.service';
+import { TypeOrmModule } from '@nestjs/typeorm';
+import { Stock } from '@/stock/domain/stock.entity';
+import { WinstonModule } from 'nest-winston';
+import { logger } from '@/configs/logger.config';
 
-describe('KoreaStockInfoService', () => {
+xdescribe('KoreaStockInfoService', () => {
   let service: KoreaStockInfoService;
 
+  // 모듈을 사용하려면 직접 DB에 연결해야함
   beforeEach(async () => {
     const module: TestingModule = await Test.createTestingModule({
+      imports: [
+        TypeOrmModule.forFeature([Stock]),
+        WinstonModule.forRoot(logger),
+      ],
       providers: [KoreaStockInfoService],
     }).compile();