Feature/#12 - 알림 구현 #313
Merged
Feature/#12 - 알림 구현 #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 1, 2024
|
남은 시간이 얼마 남지 않아 이메일은 굳이 안해도 된다고 생각합니다 |
baegyeong
approved these changes
Dec 1, 2024
Comment on lines
+33
to
+35
| } else { | ||
| if (alarm.targetPrice && alarm.targetPrice >= entity.open) { | ||
| return true; |
| endpoint: string; | ||
|
|
||
| @Column({ type: 'text' }) | ||
| p256dh: string; |
There was a problem hiding this comment.
아... 이거 명세 작성해야해요. 이건 주춤주춤 노션 페이지에 작성해놓을게요.
There was a problem hiding this comment.
web-push를 구현할 때 필요한 키값입니다! 이거 env도 같이 작성해놓을게요
저도 동의합니다! |
xjfcnfw3
approved these changes
Dec 1, 2024
| @@ -55,14 +57,17 @@ export class StockLiveDataSubscriber | |||
| changeRate: change, | |||
| volume: volume, | |||
| } = updatedStockLiveData; | |||
|
|
|||
| this.stockGateway.onUpdateStock(stockId, price, change, volume); | |||
There was a problem hiding this comment.
에러가 발생했을 때 몇 번 더 기회를 주는건 어떤가요?
There was a problem hiding this comment.
오... 좋은 거 같습니다! 이거 3번정도 기회 주는 방향으로 리팩토링하고, 차후 pr에 올릴게요!
| else throw new NotFoundException('등록된 알림을 찾을 수 없습니다.'); | ||
| } | ||
|
|
||
| async update(id: number, updateData: AlarmRequest) { |
There was a problem hiding this comment.
유저가 주인인지 확인하는 과정이 필요하다고 생각합니다
There was a problem hiding this comment.
오 감사합니다! 이거 추가해서 올릴게요!
3 tasks
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #12
✅ 작업 내용
이슈사항
✍ 궁금한 점
😎 체크 사항