Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#339 - 채팅 좋아요순 정렬 적용, 채팅 줄바꿈/엔터 전송 적용 #348

Merged
merged 14 commits into from
Dec 4, 2024

Conversation

baegyeong
Copy link
Collaborator

@baegyeong baegyeong commented Dec 3, 2024

close #339

✅ 작업 내용

  • 채팅 좋아요순 정렬 적용
  • 채팅 줄바꿈 적용
  • 채팅 엔터시 전송
  • 시가총액 억 단위 추가

📸 스크린샷(FE만)

chat.mp4

📌 이슈 사항

  • 관련 내용 위키에 적어뒀습니다!

  • 채팅 관련 리팩토링이 필요합니다.

😎 체크 사항

  • label 설정 확인
  • 브랜치 방향 확인

@baegyeong baegyeong added ✨feature 기능 개발 FE labels Dec 3, 2024
@baegyeong baegyeong requested a review from a team December 3, 2024 19:01
@baegyeong baegyeong self-assigned this Dec 3, 2024
@baegyeong baegyeong linked an issue Dec 3, 2024 that may be closed by this pull request
1 task
@@ -74,7 +74,7 @@ export const METRICS_DATA = ({
metrics: [
{
...METRIC_DETAILS.enterpriseValue.marketCap,
value: `${marketCap?.toLocaleString()}`,
value: `${marketCap?.toLocaleString()}억원`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳

Copy link
Collaborator

@swkim12345 swkim12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@xjfcnfw3 xjfcnfw3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍 👍

@swkim12345 swkim12345 merged commit 01f1c5d into dev-fe Dec 4, 2024
@swkim12345 swkim12345 deleted the feature/#339 branch December 5, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE ✨feature 기능 개발
Projects
None yet
3 participants