Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#310 - 주식 메인페이지에서 웹소켓이 연결되고 있는 문제 해결 #360

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

baegyeong
Copy link
Collaborator

close #310

✅ 작업 내용

  • 주식 상세페이지에서 웹소켓을 연결해야하는데, 메인페이지에서 연결되고 있던 문제를 해결
  • 컴포넌트가 언마운트 됐을 때 disconnect되도록 추가

😎 체크 사항

  • label 설정 확인
  • 브랜치 방향 확인

@baegyeong baegyeong added 🐞 bugfix Something isn't working FE labels Dec 4, 2024
@baegyeong baegyeong requested a review from a team December 4, 2024 07:34
@baegyeong baegyeong self-assigned this Dec 4, 2024
Copy link
Collaborator

@xjfcnfw3 xjfcnfw3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 👍

Copy link
Collaborator

@swkim12345 swkim12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@baegyeong baegyeong merged commit 72b02f8 into dev-fe Dec 4, 2024
@swkim12345 swkim12345 deleted the feature/#349 branch December 5, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE 🐞 bugfix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants