Feature/#369 eslint, 알림 string 리턴 수정, swagger 성공하게 조건 변경

packages/backend/src/alarm/alarm.controller.ts

@@ -9,13 +9,13 @@ import {
   UseGuards,
 } from '@nestjs/common';
 import {
-  ApiBadRequestResponse,
   ApiOkResponse,
   ApiOperation,
   ApiParam,
   ApiResponse,
 } from '@nestjs/swagger';
 import { AlarmService } from './alarm.service';
+import { WrongAlarmApi } from './decorator/wrong.decorator';
 import { AlarmRequest } from './dto/alarm.request';
 import { AlarmResponse, AlarmSuccessResponse } from './dto/alarm.response';
 import SessionGuard from '@/auth/session/session.guard';
@@ -36,18 +36,7 @@ export class AlarmController {
     description: '알림 생성 완료',
     type: AlarmResponse,
   })
-  @ApiBadRequestResponse({
-    description: '유효하지 않은 알람 입력값으로 인해 예외가 발생했습니다.',
-    schema: {
-      type: 'object',
-      properties: {
-        statusCode: { type: 'number', example: 400 },
-        message: { type: 'string', example: '알람 조건을 다시 확인해주세요.' },
-        error: { type: 'string', example: 'Bad Request' },
-      },
-    },
-  })
-  @UseGuards(SessionGuard)
+  @WrongAlarmApi()
   async create(
     @Body() alarmRequest: AlarmRequest,
     @GetUser() user: User,
@@ -84,13 +73,13 @@ export class AlarmController {
     type: [AlarmResponse],
   })
   @ApiParam({
-    name: 'id',
+    name: 'stockId',
     type: String,
     description: '주식 아이디',
     example: '005930',
   })
   @UseGuards(SessionGuard)
-  async getByStockId(@Param('id') stockId: string, @GetUser() user: User) {
+  async getByStockId(@Param('stockId') stockId: string, @GetUser() user: User) {
     const userId = user.id;
 
     return await this.alarmService.findByStockId(stockId, userId);
@@ -131,18 +120,7 @@ export class AlarmController {
     description: '알림 아이디',
     example: 1,
   })
-  @ApiBadRequestResponse({
-    description: '유효하지 않은 알람 입력값으로 인해 예외가 발생했습니다.',
-    schema: {
-      type: 'object',
-      properties: {
-        statusCode: { type: 'number', example: 400 },
-        message: { type: 'string', example: '알람 조건을 다시 확인해주세요.' },
-        error: { type: 'string', example: 'Bad Request' },
-      },
-    },
-  })
-  @UseGuards(SessionGuard)
+  @WrongAlarmApi()
   async update(
     @Param('id') alarmId: number,
     @Body() updateData: AlarmRequest,

packages/backend/src/alarm/decorator/wrong.decorator.ts

@@ -0,0 +1,23 @@
+import { applyDecorators, UseGuards } from '@nestjs/common';
+import { ApiBadRequestResponse } from '@nestjs/swagger';
+import SessionGuard from '@/auth/session/session.guard';
+
+export const WrongAlarmApi = () => {
+  return applyDecorators(
+    ApiBadRequestResponse({
+      description: '유효하지 않은 알람 입력값으로 인해 예외가 발생했습니다.',
+      schema: {
+        type: 'object',
+        properties: {
+          statusCode: { type: 'number', example: 400 },
+          message: {
+            type: 'string',
+            example: '알람 조건을 다시 확인해주세요.',
+          },
+          error: { type: 'string', example: 'Bad Request' },
+        },
+      },
+    }),
+    UseGuards(SessionGuard),
+  );
+};

packages/backend/src/alarm/dto/alarm.request.ts

@@ -9,14 +9,14 @@ export class AlarmRequest {
 
   @ApiProperty({
     description: '목표 가격',
-    example: 150.0,
+    example: 100000,
     required: false,
   })
   targetPrice?: number;
 
   @ApiProperty({
     description: '목표 거래량',
-    example: 1000,
+    example: 1000000000,
     required: false,
   })
   targetVolume?: number;

packages/backend/src/alarm/dto/alarm.response.ts

@@ -38,8 +38,8 @@ export class AlarmResponse {
   constructor(alarm: Alarm) {
     this.alarmId = alarm.id;
     this.stockId = alarm.stock.id;
-    this.targetPrice = alarm.targetPrice;
-    this.targetVolume = alarm.targetVolume;
+    this.targetPrice = Number(alarm.targetPrice);
+    this.targetVolume = Number(alarm.targetVolume);
     this.alarmExpiredDate = alarm.alarmExpiredDate;
   }
 }