Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#381 - 자잘한 UI 에러 수정 #385

Merged
merged 11 commits into from
Dec 5, 2024
Merged

Feature/#381 - 자잘한 UI 에러 수정 #385

merged 11 commits into from
Dec 5, 2024

Conversation

baegyeong
Copy link
Collaborator

@baegyeong baegyeong commented Dec 5, 2024 •
edited
Loading

✅ 작업 내용

  • 쿼리 캐시 무효화가 제대로 되지 않았던 문제 수정
  • 그래프 이전버전으로 롤백
  • 알림 권한 허용 alert 추가
  • 가격 등락률, 채팅 정렬 onClick 위치 변경
  • 스켈레톤 반응형/다크모드 적용

😎 체크 사항

  • label 설정 확인
  • 브랜치 방향 확인

@baegyeong baegyeong added the 🐞 bugfix Something isn't working label Dec 5, 2024
@baegyeong baegyeong requested a review from a team December 5, 2024 19:12
@baegyeong baegyeong self-assigned this Dec 5, 2024
xjfcnfw3
xjfcnfw3 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@xjfcnfw3 xjfcnfw3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 👍

swkim12345
swkim12345 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@swkim12345 swkim12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@baegyeong baegyeong merged commit 366abf8 into dev-fe Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xjfcnfw3 xjfcnfw3 xjfcnfw3 approved these changes

@swkim12345 swkim12345 swkim12345 approved these changes

Assignees

@baegyeong baegyeong

Labels
🐞 bugfix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baegyeong @swkim12345 @xjfcnfw3