Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Improve room and player validation #159

Merged
merged 4 commits into from
Nov 28, 2024
Merged

refactor: Improve room and player validation #159

merged 4 commits into from
Nov 28, 2024

Conversation

ssum1ra
Copy link
Collaborator

@ssum1ra ssum1ra commented Nov 28, 2024

πŸ“‚ μž‘μ—… λ‚΄μš©

closes #156

  • μ—†λŠ” λ°©μ΄λ‚˜ ν”Œλ ˆμ΄μ–΄ 접속 μ‹œ μ—λŸ¬ λ°˜ν™˜
  • 우승자 데이터λ₯Ό λ°°μ—΄ ꡬ쑰둜 λ¦¬νŒ©ν„°λ§
  • κ²Œμž„μ΄ 진행 쀑인 방에 μƒˆλ‘œμš΄ ν”Œλ ˆμ΄μ–΄κ°€ μ‘°μΈν•˜μ§€ λͺ»ν•˜λ„둝 μ œν•œ

πŸ’‘ μžμ„Έν•œ μ„€λͺ…

검증 둜직

  • λ°© 쑴재 μ—¬λΆ€ 체크 둜직 μΆ”κ°€
  • ν™œμ„±ν™”λœ 방의 ν”Œλ ˆμ΄μ–΄ 검증 둜직 μΆ”κ°€

λ°© μ ‘κ·Ό μ œμ–΄

  • κ²Œμž„ 진행쀑인 λ°© μž…μž₯ μ œν•œ
  • joinRoom κ²Œμ΄νŠΈμ›¨μ΄μ— status 체크 μΆ”κ°€
  • κ²Œμž„ 쀑 μž…μž₯ μ‹œλ„ μ‹œ, μ—λŸ¬ λ©”μ‹œμ§€ λ°˜ν™˜

λ°˜ν™˜ νƒ€μž…

  • 우승자 데이터 ꡬ쑰λ₯Ό λ°°μ—΄λ‘œ λ³€κ²½
  • μ •λ‹΅μžμ™€ ν•¨κ»˜ 화가도 우승자 배열에 포함
  • λ‹€μˆ˜ 우승자 처리λ₯Ό μœ„ν•œ λ°˜ν™˜ νƒ€μž… μˆ˜μ •

주의: μ‘λ‹΅μ˜ winners ν•„λ“œκ°€ 단일 μš°μŠΉμžμ—μ„œ λ°°μ—΄λ‘œ 변경됨

πŸ“— μ°Έκ³  자료 & κ΅¬ν˜„ κ²°κ³Ό (선택)

πŸ“’ 리뷰 μš”κ΅¬ 사항 (선택)

🚩 후속 μž‘μ—… (선택)

βœ… μ…€ν”„ 체크리슀트

  • PR 제λͺ©μ„ ν˜•μ‹μ— 맞게 μž‘μ„±ν–ˆλ‚˜μš”?
  • 브랜치 μ „λž΅μ— λ§žλŠ” λΈŒλžœμΉ˜μ— PR을 올리고 μžˆλ‚˜μš”? (main이 μ•„λ‹™λ‹ˆλ‹€.)
  • μ΄μŠˆλŠ” close ν–ˆλ‚˜μš”?
  • Reviewers, Labelsλ₯Ό λ“±λ‘ν–ˆλ‚˜μš”?
  • μž‘μ—… 도쀑 λ¬Έμ„œ μˆ˜μ •μ΄ ν•„μš”ν•œ 경우 잘 μˆ˜μ •ν–ˆλ‚˜μš”?
  • ν…ŒμŠ€νŠΈλŠ” 잘 ν†΅κ³Όν–ˆλ‚˜μš”?
  • λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ œκ±°ν–ˆλ‚˜μš”?

@ssum1ra ssum1ra added 🐞 BugFix Something isn't working πŸ’» BE Backend Code labels Nov 28, 2024
@ssum1ra ssum1ra added this to the Week 5 milestone Nov 28, 2024
@ssum1ra ssum1ra self-assigned this Nov 28, 2024
@ssum1ra ssum1ra linked an issue Nov 28, 2024 that may be closed by this pull request
λ°© 관리 둜직 λ¦¬νŒ©ν„°λ§ #156
Closed
3 tasks
@kwaksj329 kwaksj329 changed the title refactor: improve room and player validation refactor: Improve room and player validation Nov 28, 2024
@ssum1ra ssum1ra merged commit 74c9a4e into develop Nov 28, 2024
@ssum1ra ssum1ra deleted the feature/#156 branch December 2, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwaksj329 kwaksj329 kwaksj329 approved these changes

@choiseona choiseona choiseona approved these changes

@rhino-ty rhino-ty Awaiting requested review from rhino-ty

@dbjoung dbjoung Awaiting requested review from dbjoung

Assignees

@ssum1ra ssum1ra

Labels
πŸ’» BE Backend Code 🐞 BugFix Something isn't working
Projects
None yet
Milestone
Week 5
Development

Successfully merging this pull request may close these issues.

λ°© 관리 둜직 λ¦¬νŒ©ν„°λ§
3 participants
@ssum1ra @choiseona @kwaksj329