Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking โ€œSign up for GitHubโ€, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement game logic and UI #203

Merged
merged 5 commits into from
Dec 4, 2024
Merged

feat: Implement game logic and UI #203

merged 5 commits into from
Dec 4, 2024

Conversation

choiseona
Copy link
Collaborator

@choiseona choiseona commented Dec 4, 2024 โ€ข

๐Ÿ“‚ ์ž‘์—… ๋‚ด์šฉ

closes #179

  • ๋ผ์šด๋“œ 3,5,7,9,11
  • ์„ค์ • ๋ณ€๊ฒฝ ์‹œ infinite error ํ•ด๊ฒฐ

๐Ÿ’ก ์ž์„ธํ•œ ์„ค๋ช…

์„ค์ • ๋ฌดํ•œ ๋ฆฌ๋ Œ๋”๋ง ์ˆ˜์ •

  • ๊ธฐ์กด ์ฝ”๋“œ์—์„œ roomSetting๊ณผ selectedValue ์‚ฌ์ด์—์„œ ๋ฌดํ•œ์œผ๋กœ ๋ฆฌ๋ Œ๋”๋ง๋˜๋Š” ์ด์Šˆ๊ฐ€ ์žˆ์–ด ํ•ด๊ฒฐํ•˜์˜€์Šต๋‹ˆ๋‹ค.

๋ผ์šด๋“œ

  • ๊ธฐ์กด 3, 5 ๋ผ์šด๋“œ์—์„œ 3, 5, 7, 9, 11 ๋ผ์šด๋“œ ๊นŒ์ง€ ๋Š˜๋ ค์ฃผ์—ˆ์Šต๋‹ˆ๋‹ค.

๊ธฐํƒ€ UI ํ•ธ๋“ค๋ง

  • ๋ผ์šด๋“œ ๊ฒฐ๊ณผ ๋ชจ๋‹ฌ์—์„œ๋„ ํƒ€์ด๋จธ๋ฅผ ๋„์› ์Šต๋‹ˆ๋‹ค.
  • ๊ฒŒ์ž„ ์ƒํƒœ์— ๋”ฐ๋ผ ์ ์ ˆํ•œ ๋ฌธ๊ตฌ๋ฅผ ๋„์šฐ๋„๋ก ํ–ˆ์Šต๋‹ˆ๋‹ค. ๊ตฌ๊ฒฝ๊พผ์ด ๋งž์ถœ ๋•Œ ๊ทธ๋ฆผ๊พผ๊ณผ ๋ฐฉํ•ด๊พผ์—๊ฒŒ๋Š” ์ œ์‹œ์–ด (๋งžํžˆ๋Š”์ค‘...) ์ด ๋œจ๋„๋ก ํ•˜์˜€๊ณ , ๊ตฌ๊ฒฝ๊พผ์—๊ฒŒ๋Š” ๋งžํ˜€๋ณด์„ธ์š”-! ๊ฐ€ ๋œจ๋„๋ก ํ•˜์˜€์Šต๋‹ˆ๋‹ค. ๋˜ํ•œ ๊ตฌ๊ฒฝ๊พผ์ด ๊ทธ๋ฆผ ๊ทธ๋ฆฌ๋Š” ๊ฒƒ์„ ๊ธฐ๋‹ค๋ฆด ๋•Œ ํ™”๊ฐ€๋“ค์ด ์‹ค๋ ฅ์„ ๋ฝ๋‚ด๋Š”์ค‘... ๋ฅผ ๋„์šฐ๋„๋ก ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“— ์ฐธ๊ณ  ์ž๋ฃŒ & ๊ตฌํ˜„ ๊ฒฐ๊ณผ (์„ ํƒ)

  • ๊ตฌ๊ฒฝ๊พผ๋“ค์ด ์ •๋‹ต์„ ๋งžํž ๋•Œ ๊ทธ๋ฆผ๊พผ๊ณผ ๋ฐฉํ•ด๊พผ๋“ค์—๊ฒŒ๋Š” ์ œ์‹œ์–ด (๋งžํžˆ๋Š”์ค‘...) ์„ ๋„์›Œ์ค๋‹ˆ๋‹ค
image
  • ๊ตฌ๊ฒฝ๊พผ๋“ค์ด ์ •๋‹ต์„ ๋งžํž ๋•Œ ๊ตฌ๊ฒฝ๊พผ๋“ค์—๊ฒŒ๋Š” ๋งžํ˜€๋ณด์„ธ์š”-!๋ฅผ ๋„์›Œ์ค๋‹ˆ๋‹ค.
image
  • ๊ตฌ๊ฒฝ๊พผ๋“ค์ด ๊ทธ๋ฆผ์„ ๊ธฐ๋‹ค๋ฆด ๋•Œ ํ™”๊ฐ€๋“ค์ด ์‹ค๋ ฅ์„ ๋ฝ๋‚ด๋Š”์ค‘...์„ ๋„์›Œ์ค๋‹ˆ๋‹ค.
image
  • ๋ผ์šด๋“œ ์ข…๋ฃŒ ๋ชจ๋‹ฌ ์นด์šดํŠธ ๋‹ค์šด์„ ๋„์›Œ์ค๋‹ˆ๋‹ค. ์ค‘์š”ํ•œ ์ •๋ณด๊ฐ€ ์•„๋‹ˆ๋ผ๊ณ  ์ƒ๊ฐ๋˜์–ด ์˜…์€ ์ƒ‰์œผ๋กœ ๋„์› ์Šต๋‹ˆ๋‹ค.
image

๐Ÿ“ข ๋ฆฌ๋ทฐ ์š”๊ตฌ ์‚ฌํ•ญ (์„ ํƒ)

๐Ÿšฉ ํ›„์† ์ž‘์—… (์„ ํƒ)

โœ… ์…€ํ”„ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • PR ์ œ๋ชฉ์„ ํ˜•์‹์— ๋งž๊ฒŒ ์ž‘์„ฑํ–ˆ๋‚˜์š”?
  • ๋ธŒ๋žœ์น˜ ์ „๋žต์— ๋งž๋Š” ๋ธŒ๋žœ์น˜์— PR์„ ์˜ฌ๋ฆฌ๊ณ  ์žˆ๋‚˜์š”? (main์ด ์•„๋‹™๋‹ˆ๋‹ค.)
  • ์ด์Šˆ๋Š” close ํ–ˆ๋‚˜์š”?
  • Reviewers, Labels๋ฅผ ๋“ฑ๋กํ–ˆ๋‚˜์š”?
  • ์ž‘์—… ๋„์ค‘ ๋ฌธ์„œ ์ˆ˜์ •์ด ํ•„์š”ํ•œ ๊ฒฝ์šฐ ์ž˜ ์ˆ˜์ •ํ–ˆ๋‚˜์š”?
  • ํ…Œ์ŠคํŠธ๋Š” ์ž˜ ํ†ต๊ณผํ–ˆ๋‚˜์š”?
  • ๋ถˆํ•„์š”ํ•œ ์ฝ”๋“œ๋Š” ์ œ๊ฑฐํ–ˆ๋‚˜์š”?

@choiseona choiseona added โœจ Feature New feature or request ๐ŸŽจ HTML&CSS Markup & Styles ๐Ÿ’ป FE Frontend Code labels Dec 4, 2024
@choiseona choiseona added this to the Week 6 milestone Dec 4, 2024
@choiseona choiseona self-assigned this Dec 4, 2024
@choiseona choiseona linked an issue Dec 4, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

github-actions bot commented Dec 4, 2024

๐Ÿ“š Storybook preview deployed to: Visit Storybook Preview

Copy link
Member

@kwaksj329 kwaksj329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์„ ์•„๋‹˜ ์งฑ์งฑ๊ฑธ ๊ณ ์ƒํ•˜์…จ์–ด์š”!!

@choiseona choiseona merged commit 584b396 into develop Dec 4, 2024
2 checks passed
Copy link
Contributor

github-actions bot commented Dec 4, 2024

๐Ÿงน Storybook preview for PR #203 has been removed.

github-actions bot added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ’ป FE Frontend Code โœจ Feature New feature or request ๐ŸŽจ HTML&CSS Markup & Styles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] ์„ค์ • ๋ณ€๊ฒฝ ๋กœ์ง ์ˆ˜์ •
3 participants