-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions/add geojson writer #1351
Merged
barendgehrels
merged 3 commits into
boostorg:develop
from
barendgehrels:extensions/add-geojson-writer
Jan 10, 2025
Merged
Extensions/add geojson writer #1351
barendgehrels
merged 3 commits into
boostorg:develop
from
barendgehrels:extensions/add-geojson-writer
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barendgehrels
commented
Dec 6, 2024
include/boost/geometry/extensions/gis/io/geojson/geojson_writer.hpp
Outdated
Show resolved
Hide resolved
@tinko92 for some reason I cannot add you to the reviewers |
tinko92
reviewed
Dec 14, 2024
include/boost/geometry/extensions/gis/io/geojson/geojson_writer.hpp
Outdated
Show resolved
Hide resolved
include/boost/geometry/extensions/gis/io/geojson/geojson_writer.hpp
Outdated
Show resolved
Hide resolved
include/boost/geometry/extensions/gis/io/geojson/geojson_writer.hpp
Outdated
Show resolved
Hide resolved
barendgehrels
force-pushed
the
extensions/add-geojson-writer
branch
3 times, most recently
from
December 15, 2024 11:49
77a1483
to
e7ae131
Compare
Looks good to me! |
barendgehrels
force-pushed
the
extensions/add-geojson-writer
branch
from
December 30, 2024 07:20
e7ae131
to
f1f20eb
Compare
vissarion
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how I usually test now. It is way more convenient than SVG.
For example (
case_multi_simplex
), in QGisupdate
The last commits also allow showing operation types and travel-to information, often quite useful.