-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix borgmatic removal of config-sections #135
base: master
Are you sure you want to change the base?
Conversation
Hey, thanks for adding this! Since this breaks older borgmatic versions (e.g. if someone installs from a system package) we should probably bump the major version for this. |
I started experiencing these warnings a couple of days ago after I upgraded borgmatic and was JUST about to open an issue when I decided to check PRs and see if anyone else had submitted anything for it. Thanks @raph2i very much for submitting the PR. @m3nu is there a timeline for the new major version and when it might hit Ansible Galaxy? |
There's still a small nitpick for this.
But borgmatic is still somehow complaining about the top level sections in the config file with no further details |
Well, if we merge this, it will break for all older versions. That's versus having warnings in newer versions. |
That's indeed a problem I currently have with my infra. I will try to build upon this to make a version detection and switch the template if i have the time |
hi, as this as been stale for about a year, is there any plan to merge this? |
{{ hook }}: | ||
{{ borgmatic_hooks[hook] | to_nice_yaml(indent=2) | trim | indent(8) }} | ||
{{ hook }}: | ||
{{ borgmatic_hooks[hook] | to_nice_yaml(indent=2) | trim | indent(8) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there,
since borgmatic 1.8 the configuration sections "location, storage, etc." are no longer needed.
as seen on: https://projects.torsion.org/borgmatic-collective/borgmatic/issues/721