Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typing:
src/vorta/store
#1872base: master
Are you sure you want to change the base?
typing:
src/vorta/store
#1872Changes from 13 commits
6abd0f5
7b80066
5f07abd
b4f2e64
4b299f9
d21316b
4f03af6
767dcc1
1d76358
a5c6729
2f40b7c
77f5c33
f0f33c7
5f5b4e3
0c3829c
eee0b42
65fa36b
bef54e1
73e7d96
8d4ed3b
ba695dd
59803e6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is proper use of type hints. Shouldn't it be the following instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last_scheduled_backups_per_profile
just a bit below (line 71) was assigned like that ( = Tuple(...)) so, I did it tolast_backups_per_profile
for consistency. I think it would be better to do it according to your suggestion or keep both like: