-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add exclude patterns for most common media files and .part files #2145
Conversation
Thanks for the contribution! Wanna move them to a separate file and make the groups you suggested? Could be nice, I think. |
good suggestion to add separate file. Like media.json?
Should I do that in this PR or in a later PR? Did you intend to make a merge commit on my branch? Instead of merging it into main branch? |
at the very least used by firefox unfinished downloads
I sorted the list and copied most of https://en.wikipedia.org/wiki/Video_file_format
I would do it in the same PR, since it's a small change. I've rebased your branch to include the latest changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks for the change and contribution. Looks all good. Anything to add before merging? |
It's fine |
adds more exclusion presets related to media files, video and audio.
No picture formats because they were not added the originally
Does it make sense to split them up in music, video and images in the future?
Possibly make a new file for just media formats as they are now in dev.json
Description
Related Issue
Motivation and Context
How Has This Been Tested?
I did not test anythingjson is valid
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.