Wait on network to be available before trying to run backups against remote repos #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzeigler
force-pushed
the
wait-for-network
branch
2 times, most recently
from
2fe7de9 to
eaaadf0
Compare
Don't try and start jobs with remote repos until the network is up. This should prevent job failures when, for instance, waking from sleep. Mac implementation is a stub currently. Signed-off-by: Ryan Zeigler <[email protected]>
rzeigler
force-pushed
the
wait-for-network
branch
from
eaaadf0 to
42e8bf9
Compare
Signed-off-by: Ryan Zeigler <[email protected]>
rzeigler
force-pushed
the
wait-for-network
branch
from
cce8273 to
efc04e1
Compare
NetworkStatusMonitor is now a QObject with signal network_status_changed. The scheduler listens to this signal and handles rescheduling similar to the existing 'wake from suspend' logic works. Signed-off-by: Ryan Zeigler <[email protected]>
|
I didn't like the timer firing constantly so I have reworked this to listen for network manager events. |
It seems that sometimes the signal does't arrive. Signed-off-by: Ryan Zeigler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reactively disable scheduled jobs against remote repositories when there is no network connection.
Related Issue
#2133
Motivation and Context
Running a backup against a remote repo will fail without a network connection.
This results in a notification on default settings, stress (because why are my backups failing) and could maybe result in backups not happening.
On my Linux systems configured to sleep, the first backup after resuming always seems to fail because the network has not finished activating yet.
This should allow that backup to just wait for a little while.
As a side benefit, this should also defer backups that happen in the normal course when there is no possible way they could work (i.e. when in airplane mode).
I thought about these changes for a little and its what I came up with. However, if the maintainers have a different approach they would like to try I'm more than willing to rework my PR or open a new one with that approach. I do also have a mac that I can in theory develop the stubbed mac implementation here, but I'm less familiar with how to programatically access the state of the mac network. If this approach is good, I can flesh that out also.
How Has This Been Tested?
I had a little bit of trouble figuring out how to manipulate vorta's database state so that I could actually start vorta, then put my system to sleep. Vorta always wanted to backup immediately. I assume this should be a reasonable facsimile of the behavior.
Regarding actual tests, I am not an experienced python developer and running nox locally seems to fail to collect tests in test_darwin.py which I wouldn't expect to execute at all on my system. That said, I don't think I changed anything covered by unit tests.
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.