Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernization #15

Open
14 of 32 tasks
jcorbin opened this issue Feb 17, 2021 · 4 comments
Open
14 of 32 tasks

Modernization #15

jcorbin opened this issue Feb 17, 2021 · 4 comments
Assignees

Comments

@jcorbin
Copy link
Collaborator

jcorbin commented Feb 17, 2021

@jcorbin jcorbin self-assigned this Feb 17, 2021
@jcorbin
Copy link
Collaborator Author

jcorbin commented Feb 26, 2021

Update: istanbul's use of esprima blocks #21 similarly to eslint's parser issues; will update to nyc next, and sort out it's parsing deal

@kriskowal
Copy link
Member

pop-equals could probably be inline or simplified. It’s one of my own dead-ends.

tee could probably be inlined and simplified. Just need an object that forwards to two.

shon is also an ill-advised kris special but one I like if you’re up for lifting it upstream.

@jcorbin
Copy link
Collaborator Author

jcorbin commented Mar 2, 2021

Updated now that we're past the eslint:recommended gate

Next step is a side quest for kni.js test coverage, as revealed by the latent bug discovered in #37

Considering doing a patch release for v3 and v4 including that fix plus the ceil/round bugs fixed in #17

@jcorbin
Copy link
Collaborator Author

jcorbin commented Mar 2, 2021

Also will probably drop all the // istanbul ignore ... comments, and track towards enabling "all sources" mode to make our coverage numbers more honest as speculated in #34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants