grammar: use destructuring in Label #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
reviewed
Mar 2, 2021
grammar.js
Outdated
| const label = expression[1]; | ||
| const [head, ...tail] = expression; | ||
| if (head === 'get') { | ||
| const label = tail[0]; |
There was a problem hiding this comment.
Would even buy const [label] = tail.
grammar.js
Outdated
| const labelScope = scope.label(label); | ||
| } else if (head === 'call') { | ||
| const [label, ...args] = tail; | ||
| const labelScope = scope.label(label[1]); // XXX why the [1]? |
There was a problem hiding this comment.
This might be more clear with an assert(label[0] === 'get') present, since the expectation is that an expression like foo will parse into an S-expression AST like ['get', 'foo'].
There was a problem hiding this comment.
Hmm, I guess what confused me, is that the branch above is treating label there as an atom, where-as here it's deconstructed; but I guess the above branch just passes the s-expr through?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjacent to, but not blocking, eslint:recommended gate towards #15
Question about what look like a spurious / double
[1]index preserved from prior @kriskowal