Merge pull request RIOT-OS#13288 from catcombo/fix-ds18-temperature-c…

…onversion Fix ds18 temperature conversion
bosmoment · Feb 7, 2020 · 5a4d39e · 5a4d39e
2 parents dfcf155 + 234313a
commit 5a4d39e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/drivers/ds18/ds18.c b/drivers/ds18/ds18.c
@@ -184,8 +184,8 @@ int ds18_read(const ds18_t *dev, int16_t *temperature)
 
     DEBUG("[DS18] Received byte: 0x%02x\n", b2);
 
-    int32_t measurement = ((int16_t)(b2 << 8 | b1) * 625);
-    *temperature = (int16_t)(measurement / 100);
+    int32_t measurement = (int16_t)(b2 << 8 | b1);
+    *temperature = (int16_t)((100 * measurement) >> 4);
 
     return DS18_OK;
 }

diff --git a/tests/driver_ds18/Makefile b/tests/driver_ds18/Makefile
@@ -1,6 +1,6 @@
 include ../Makefile.tests_common
 
-BOARD_WHITELIST := sensebox_samd21 samr21-xpro nucleo-l152re nucleo-l432kc nucleo-l073rz b-l072z-lrwan
+BOARD_WHITELIST := sensebox_samd21 samr21-xpro nucleo-l152re nucleo-l432kc nucleo-l073rz b-l072z-lrwan arduino-nano
 
 USEMODULE += ds18
 USEMODULE += xtimer