Price discovery offers must have 0 initial price (#909)

* Update solidity code

* Unit tests

contracts/domain/BosonErrors.sol

@@ -174,6 +174,8 @@ interface BosonErrors {
     error InvalidRoyaltyInfo();
     // Trying to change the default recipient address (treasury)
     error WrongDefaultRecipient();
+    // Price discovery offer has non zero price
+    error InvalidPriceDiscoveryPrice();
 
     // Group related
     // Group does not exist

contracts/interfaces/handlers/IBosonOfferHandler.sol

@@ -31,6 +31,7 @@ interface IBosonOfferHandler is BosonErrors, IBosonOfferEvents {
      * - Resolution period is not between the minimum and the maximum resolution period
      * - Voided is set to true
      * - Available quantity is set to zero
+     * - Offer type is discovery and the price is not set to zero
      * - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      * - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      * - Seller is not on dispute resolver's seller allow list
@@ -81,6 +82,7 @@ interface IBosonOfferHandler is BosonErrors, IBosonOfferEvents {
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list

contracts/interfaces/handlers/IBosonOrchestrationHandler.sol

@@ -91,6 +91,7 @@ interface IBosonOrchestrationHandler is
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list
@@ -170,6 +171,7 @@ interface IBosonOrchestrationHandler is
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list
@@ -232,6 +234,7 @@ interface IBosonOrchestrationHandler is
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list
@@ -290,6 +293,7 @@ interface IBosonOrchestrationHandler is
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list
@@ -349,6 +353,7 @@ interface IBosonOrchestrationHandler is
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list
@@ -409,6 +414,7 @@ interface IBosonOrchestrationHandler is
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list
@@ -471,6 +477,7 @@ interface IBosonOrchestrationHandler is
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list
@@ -537,6 +544,7 @@ interface IBosonOrchestrationHandler is
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list
@@ -606,6 +614,7 @@ interface IBosonOrchestrationHandler is
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list
@@ -677,6 +686,7 @@ interface IBosonOrchestrationHandler is
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list
@@ -767,6 +777,7 @@ interface IBosonOrchestrationHandler is
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list
@@ -852,6 +863,7 @@ interface IBosonOrchestrationHandler is
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list
@@ -939,6 +951,7 @@ interface IBosonOrchestrationHandler is
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list
@@ -1032,6 +1045,7 @@ interface IBosonOrchestrationHandler is
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list
@@ -1127,6 +1141,7 @@ interface IBosonOrchestrationHandler is
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list
@@ -1225,6 +1240,7 @@ interface IBosonOrchestrationHandler is
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list

contracts/protocol/bases/OfferBase.sol

@@ -30,6 +30,7 @@ contract OfferBase is ProtocolBase, IBosonOfferEvents {
      * - Resolution period is not between the minimum and the maximum resolution period
      * - Voided is set to true
      * - Available quantity is set to zero
+     * - Offer type is discovery and the price is not set to zero
      * - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      * - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      * - Seller is not on dispute resolver's seller allow list
@@ -96,6 +97,7 @@ contract OfferBase is ProtocolBase, IBosonOfferEvents {
      * - Resolution period is not between the minimum and the maximum resolution period
      * - Voided is set to true
      * - Available quantity is set to zero
+     * - Offer type is discovery and the price is not set to zero
      * - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      * - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      * - Seller is not on dispute resolver's seller allow list
@@ -147,6 +149,9 @@ contract OfferBase is ProtocolBase, IBosonOfferEvents {
         // quantity must be greater than zero
         if (_offer.quantityAvailable == 0) revert InvalidQuantityAvailable();
 
+        // If offer is of the discovery type, price must be zero
+        if (_offer.priceType == PriceType.Discovery && _offer.price != 0) revert InvalidPriceDiscoveryPrice();
+
         DisputeResolutionTerms memory disputeResolutionTerms;
         OfferFees storage offerFees = fetchOfferFees(_offer.id);
         {

contracts/protocol/facets/OfferHandlerFacet.sol

@@ -38,6 +38,7 @@ contract OfferHandlerFacet is IBosonOfferHandler, OfferBase {
      * - Resolution period is not between the minimum and the maximum resolution period
      * - Voided is set to true
      * - Available quantity is set to zero
+     * - Offer type is discovery and the price is not set to zero
      * - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      * - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      * - Seller is not on dispute resolver's seller allow list
@@ -90,6 +91,7 @@ contract OfferHandlerFacet is IBosonOfferHandler, OfferBase {
      *   - Resolution period is not between the minimum and the maximum resolution period
      *   - Voided is set to true
      *   - Available quantity is set to zero
+     *   - Offer type is discovery and the price is not set to zero
      *   - Dispute resolver wallet is not registered, except for absolute zero offers with unspecified dispute resolver
      *   - Dispute resolver is not active, except for absolute zero offers with unspecified dispute resolver
      *   - Seller is not on dispute resolver's seller allow list