fix: do not create an offer when the seller does not exist

bosonprotocol · Nov 27, 2023 · cb617ac · cb617ac
1 parent f2ab29e
commit cb617ac
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/packages/subgraph/src/mappings/account-handler.ts b/packages/subgraph/src/mappings/account-handler.ts
@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/ban-types */
+import { BigInt } from "@graphprotocol/graph-ts";
 import {
   SellerCreated,
   SellerUpdatePending,
@@ -36,6 +38,11 @@ import { saveAccountEventLog } from "../entities/event-log";
 import { saveSellerMetadata } from "../entities/metadata/handler";
 import { getSellerMetadataEntityId } from "../entities/metadata/seller";
 
+export function checkSellerExist(sellerId: BigInt): boolean {
+  const seller = Seller.load(sellerId.toString());
+  return !!seller;
+}
+
 export function handleSellerCreatedEventWithoutMetadataUri(
   event: SellerCreatedLegacy
 ): void {

diff --git a/packages/subgraph/src/mappings/offer-handler.ts b/packages/subgraph/src/mappings/offer-handler.ts
@@ -1,4 +1,4 @@
-import { BigInt } from "@graphprotocol/graph-ts";
+import { BigInt, log } from "@graphprotocol/graph-ts";
 import {
   OfferCreated,
   OfferVoided,
@@ -17,6 +17,7 @@ import {
   saveDisputeResolutionTermsLegacy
 } from "../entities/dispute-resolution";
 import { saveOfferEventLog } from "../entities/event-log";
+import { checkSellerExist } from "./account-handler";
 
 export function handleOfferCreatedEvent(event: OfferCreated): void {
   const offerId = event.params.offerId;
@@ -30,6 +31,14 @@ export function handleOfferCreatedEvent(event: OfferCreated): void {
     const offerFeesStruct = event.params.offerFees;
     const disputeResolutionTermsStruct = event.params.disputeResolutionTerms;
 
+    if (!checkSellerExist(offerStruct.sellerId)) {
+      log.warning(
+        "Offer '{}' won't be created because seller '{}' does not exist",
+        [offerId.toString(), offerStruct.sellerId.toString()]
+      );
+      return;
+    }
+
     offer = new Offer(offerId.toString());
     offer.createdAt = event.block.timestamp;
     offer.price = offerStruct.price;
@@ -97,6 +106,14 @@ export function handleOfferCreatedEventLegacy(event: OfferCreatedLegacy): void {
     const offerFeesStruct = event.params.offerFees;
     const disputeResolutionTermsStruct = event.params.disputeResolutionTerms;
 
+    if (!checkSellerExist(offerStruct.sellerId)) {
+      log.warning(
+        "Offer '{}' won't be created because seller '{}' does not exist",
+        [offerId.toString(), offerStruct.sellerId.toString()]
+      );
+      return;
+    }
+
     offer = new Offer(offerId.toString());
     offer.createdAt = event.block.timestamp;
     offer.price = offerStruct.price;