Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update contract offers no expiration #616

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

albertfolch-redeemeum
Copy link
Collaborator

No description provided.

@albertfolch-redeemeum albertfolch-redeemeum marked this pull request as ready for review November 30, 2023 17:17
Copy link
Member

@levalleux-ludo levalleux-ludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79983d1) 84.49% compared to head (7c9d671) 84.50%.
Report is 3 commits behind head on main.

❗ Current head 7c9d671 differs from pull request most recent head b03cd1b. Consider uploading reports for the commit b03cd1b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
+ Coverage   84.49%   84.50%   +0.01%     
==========================================
  Files         137      137              
  Lines        4076     4079       +3     
  Branches      716      718       +2     
==========================================
+ Hits         3444     3447       +3     
  Misses        632      632              
Flag Coverage Δ
common 85.11% <ø> (ø)
core-sdk 50.14% <100.00%> (+0.04%) ⬆️
e2e 83.57% <100.00%> (+0.01%) ⬆️
eth-connect-sdk 18.30% <ø> (ø)
ethers-sdk 67.63% <ø> (ø)
ipfs-storage 94.02% <ø> (ø)
metadata 94.44% <ø> (ø)
unittests 53.95% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertfolch-redeemeum albertfolch-redeemeum merged commit 3954ade into main Dec 1, 2023
4 checks passed
@albertfolch-redeemeum albertfolch-redeemeum deleted the update-contracts-offers-no-expiration branch December 1, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants