feat: manage collections at seller level #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levalleux-ludo
changed the title
albertfolch-redeemeum
approved these changes
Dec 15, 2023
| web3Lib: args.web3Lib | ||
| }); | ||
| if (!isAvailable) { | ||
| const uuid = Math.floor(Math.random() * 100000000).toFixed(0); |
There was a problem hiding this comment.
Suggested change
| const uuid = Math.floor(Math.random() * 100000000).toFixed(0); | |
| const uuid = crypto.randomUUID(); |
There was a problem hiding this comment.
I've finally reverted as the crypto symbol is not resolved in tests...
Co-authored-by: albertfolch-redeemeum <[email protected]>
…ocol/core-components into 547-manage-collections
This reverts commit 9de53e2.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
==========================================
+ Coverage 84.49% 84.88% +0.39%
==========================================
Files 137 137
Lines 4076 4182 +106
Branches 716 737 +21
==========================================
+ Hits 3444 3550 +106
Misses 632 632
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #547
How to test
new e2e tests
core-sdk-collections.test.ts