Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-uploader): add text ellipsis and adjust spacing #3479

Merged
merged 2 commits into from
Jan 5, 2024
Merged

fix(content-uploader): add text ellipsis and adjust spacing #3479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ff17d6
fix(content-uploader): add text ellipsis and adjust spacing
tjuanitas Dec 29, 2023
2a55789
Merge branch 'master' into fix-content-uploader-file-name
mergify[bot] Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/elements/content-uploader/ItemName.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@import '../common/variables';

.bcu-item-label {
max-width: 300px;
width: 100%;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing max-width will support longer file names in large screen sizes

Before
Screenshot 2023-12-29 at 12 23 27 PM

After
Screenshot 2023-12-29 at 12 24 16 PM
Screenshot 2023-12-29 at 12 24 57 PM

overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
Expand Down
4 changes: 4 additions & 0 deletions src/elements/content-uploader/ProgressBar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
background: $bdl-gray-10;
transition: .4s opacity;

.be-is-small & {
margin-right: $bdl-grid-unit * 6;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was the spacing before??

}

.bcu-progress {
top: 0;
left: 0;
Expand Down
Loading