chore(content-uploader): Migrate UploadInput #3594
Conversation
greg-in-a-box
force-pushed
the
cu-uploadinput
branch
5 times, most recently
from
f495a33 to
127c59f
Compare
| // https://stackoverflow.com/questions/72787050/typescript-upload-directory-property-directory-does-not-exist-on-type | ||
| // Extend the InputHTMLAttributes interface to include the directory attribute | ||
| declare module 'react' { | ||
| interface InputHTMLAttributes<T> extends React.HTMLAttributes<T> { | ||
| directory?: string; | ||
| webkitdirectory?: string; | ||
| } | ||
| } |
There was a problem hiding this comment.
should this exist in some global or common types location? other upload inputs would encounter the same error too right?
There was a problem hiding this comment.
This is the only input we are doing this in, I didnt see a reason to let the rest of them know they have two more props
| /* eslint-disable */ // Disabling linting for tabIndex on label, unknown why it's there | ||
| import * as React from 'react'; |
There was a problem hiding this comment.
are we able to disable the specific error instead of the whole file?
There was a problem hiding this comment.
this was the alt
// eslint-disable-next-line jsx-a11y/no-noninteractive-tabindex,jsx-a11y/no-noninteractive-element-interactions <label className={inputLabelClass} onKeyDown={onKeyDown} tabIndex={0}>
thoughts on which one you think we should use?
There was a problem hiding this comment.
my thinking is we want to be putting role="button" on the label
There was a problem hiding this comment.
gives the same lint error with role="button"
There was a problem hiding this comment.
i think it narrowed it to a separate eslint error jsx-a11y/no-noninteractive-element-to-interactive-role which is more manageable
but we also disable the other two errors in a few of the elements already:
box-ui-elements/src/elements/content-preview/ContentPreview.js
Lines 1317 to 1318 in 219300f
| } | ||
| } | ||
|
|
||
| export interface Props { |
There was a problem hiding this comment.
current pattern:
| export interface Props { | |
| export interface UploadInputProps { |
| }; | ||
| export default UploadInput; |
There was a problem hiding this comment.
super nit if you get to it:
| }; | |
| export default UploadInput; | |
| }; | |
| export default UploadInput; |
greg-in-a-box
force-pushed
the
cu-uploadinput
branch
from
127c59f to
43375b0
Compare
greg-in-a-box
force-pushed
the
cu-uploadinput
branch
from
43375b0 to
4b613ba
Compare
.jsto.js.flow