chore(content-uploader): Migrated ItemAction #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-in-a-box
force-pushed
the
cu-uploadstate
branch
from
34feaea to
206de33
Compare
JChan106
reviewed
Aug 5, 2024
| @@ -63,15 +63,15 @@ const ItemList = ({ | |||
| cellRenderer={actionCell} | |||
| dataKey="status" | |||
| flexShrink={0} | |||
| width={onUpgradeCTAClick ? 100 : 25} | |||
| width={onUpgradeCTAClick ? 100 : 32} | |||
There was a problem hiding this comment.
can we store this in a constant
greg-in-a-box
force-pushed
the
cu-uploadstate
branch
from
206de33 to
fa71b26
Compare
JChan106
reviewed
Aug 5, 2024
| /> | ||
| {isResumableUploadsEnabled && ( | ||
| <Column | ||
| className="bcu-item-list-action-column" | ||
| cellRenderer={removeCell} | ||
| dataKey="remove" | ||
| flexShrink={0} | ||
| width={25} | ||
| width={32} |
There was a problem hiding this comment.
I was thinking more of storing 100/32 as a constant so that it can be used in both places
greg-in-a-box
force-pushed
the
cu-uploadstate
branch
from
fa71b26 to
35f7b0b
Compare
JChan106
approved these changes
Aug 5, 2024
QingyuChai
reviewed
Aug 6, 2024
Comment on lines
+4
to
+5
| import { IntlProvider } from 'react-intl'; | ||
| import { TooltipProvider } from '@box/blueprint-web'; |
There was a problem hiding this comment.
How come this test isn't migrated, but ItemAction.test.tsx is? Did we decide to do this as a separate task?
QingyuChai
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.jsto.js.flowTooltipProviderto the root of the ContentUploader - Also added it to the testing-library utility