feat(metadata-sidebar): Add metadata add template dropdown menu #3606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jankowiakdawid
force-pushed
the
add-metadata-add-template-dropdown-menu
branch
2 times, most recently
from
cfd8145 to
216c8c3
Compare
wpiesiak
reviewed
Aug 14, 2024
JChan106
reviewed
Aug 14, 2024
greg-in-a-box
changed the title
wpiesiak
force-pushed
the
metadata-sidebar-redesign
branch
from
e5acb6f to
4bf0c9e
Compare
wpiesiak
force-pushed
the
metadata-sidebar-redesign
branch
from
4bf0c9e to
897a5c7
Compare
JChan106
requested changes
Aug 19, 2024
greg-in-a-box
requested changes
Aug 20, 2024
src/elements/content-sidebar/stories/MetadataSidebarRedesign-interaction.stories.tsx
Outdated
Show resolved
Hide resolved
src/elements/content-sidebar/stories/MetadataSidebarRedesign-interaction.stories.tsx
Outdated
Show resolved
Hide resolved
src/elements/content-sidebar/stories/MetadataSidebarRedesign-interaction.stories.tsx
Outdated
Show resolved
Hide resolved
src/elements/content-sidebar/__tests__/MetadataSidebarRedesign.test.tsx
Outdated
Show resolved
Hide resolved
src/elements/content-sidebar/__tests__/MetadataSidebarRedesign.test.tsx
Outdated
Show resolved
Hide resolved
and improve basic styling
Extend Jest configuration to not transforming metadata-editor code
To MetadataSidebarRedesign
No idea why they got there in the first place
karolinaru
force-pushed
the
add-metadata-add-template-dropdown-menu
branch
from
bc54500 to
136da36
Compare
bfoxx1906
reviewed
Aug 21, 2024
| } | ||
|
|
||
| export interface ErrorContextProps { | ||
| onError: (error: ElementsXhrError | Error, code: string, contextInfo?: Object, origin?: ElementOrigin) => void; |
There was a problem hiding this comment.
Can we get a stronger type than Object here?
| type MetadataSidebarRedesignProps, | ||
| } from '../MetadataSidebarRedesign'; | ||
|
|
||
| describe('elements/content-sidebar/Metadata/MetadataSidebarRedesign', () => { |
There was a problem hiding this comment.
Don't we need tests for the errorMessage and loading indicator?
greg-in-a-box
requested changes
Aug 21, 2024
src/elements/content-sidebar/__tests__/useSidebarMetadataFetcher.test.tsx
Outdated
Show resolved
Hide resolved
src/elements/content-sidebar/stories/MetadataSidebarRedesign.stories.tsx
Outdated
Show resolved
Hide resolved
tjuanitas
reviewed
Aug 21, 2024
tjuanitas
reviewed
Aug 21, 2024
| </h3> | ||
| <hr /> | ||
| <p>Hello from Metadata Sidebar redesign</p> | ||
| <div className="bcs-MetadataSidebarRedesign bcs-content"> |
There was a problem hiding this comment.
what's the longterm plan? will this be refactored to use SidebarContent or is that component going away?
There was a problem hiding this comment.
Good catch! I've changed implementation to use SidebarContent
|
|
tjuanitas
approved these changes
Aug 22, 2024
src/elements/content-sidebar/__tests__/MetadataSidebarRedesign.test.tsx
Outdated
Show resolved
Hide resolved
greg-in-a-box
approved these changes
Aug 23, 2024
jankowiakdawid
added a commit
that referenced
this pull request
Aug 29, 2024
* feat(metadata-sidebar): Add AddMetadataTemplateDropdown and improve basic styling * feat(metadata-sidebar): Fix failing tests Extend Jest configuration to not transforming metadata-editor code * feat(metadata-sidebar): add AddMetadataTemplateDropdown To MetadataSidebarRedesign * feat(content-sidebar): Bring back changes to mockServiceWorker.js No idea why they got there in the first place * feat(metadata-sidebar): update storybook * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): simplify storybook * feat(metadata-sidebar): enum status * feat(metadata-sidebar): global variables and enum upper case change * feat(metadata-sidebar): useSidebarMetadataFetcher tests * feat(metadata-sidebar): useSidebarMetadataFetcher tests * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): loading status test * feat(metadata-sidebar): use SidebarContent + tests * feat(metadata-sidebar): template dropdown menu nit fixes --------- Co-authored-by: Karolina Rusek-Bieniek <[email protected]> Co-authored-by: Wiola <[email protected]>
jankowiakdawid
added a commit
that referenced
this pull request
Sep 6, 2024
* feat(metadata-sidebar): Add AddMetadataTemplateDropdown and improve basic styling * feat(metadata-sidebar): Fix failing tests Extend Jest configuration to not transforming metadata-editor code * feat(metadata-sidebar): add AddMetadataTemplateDropdown To MetadataSidebarRedesign * feat(content-sidebar): Bring back changes to mockServiceWorker.js No idea why they got there in the first place * feat(metadata-sidebar): update storybook * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): simplify storybook * feat(metadata-sidebar): enum status * feat(metadata-sidebar): global variables and enum upper case change * feat(metadata-sidebar): useSidebarMetadataFetcher tests * feat(metadata-sidebar): useSidebarMetadataFetcher tests * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): loading status test * feat(metadata-sidebar): use SidebarContent + tests * feat(metadata-sidebar): template dropdown menu nit fixes --------- Co-authored-by: Karolina Rusek-Bieniek <[email protected]> Co-authored-by: Wiola <[email protected]>
jankowiakdawid
added a commit
that referenced
this pull request
Sep 11, 2024
* feat(metadata-sidebar): Add AddMetadataTemplateDropdown and improve basic styling * feat(metadata-sidebar): Fix failing tests Extend Jest configuration to not transforming metadata-editor code * feat(metadata-sidebar): add AddMetadataTemplateDropdown To MetadataSidebarRedesign * feat(content-sidebar): Bring back changes to mockServiceWorker.js No idea why they got there in the first place * feat(metadata-sidebar): update storybook * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): simplify storybook * feat(metadata-sidebar): enum status * feat(metadata-sidebar): global variables and enum upper case change * feat(metadata-sidebar): useSidebarMetadataFetcher tests * feat(metadata-sidebar): useSidebarMetadataFetcher tests * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): loading status test * feat(metadata-sidebar): use SidebarContent + tests * feat(metadata-sidebar): template dropdown menu nit fixes --------- Co-authored-by: Karolina Rusek-Bieniek <[email protected]> Co-authored-by: Wiola <[email protected]>
jankowiakdawid
added a commit
that referenced
this pull request
Sep 13, 2024
* feat(metadata-sidebar): Add AddMetadataTemplateDropdown and improve basic styling * feat(metadata-sidebar): Fix failing tests Extend Jest configuration to not transforming metadata-editor code * feat(metadata-sidebar): add AddMetadataTemplateDropdown To MetadataSidebarRedesign * feat(content-sidebar): Bring back changes to mockServiceWorker.js No idea why they got there in the first place * feat(metadata-sidebar): update storybook * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): simplify storybook * feat(metadata-sidebar): enum status * feat(metadata-sidebar): global variables and enum upper case change * feat(metadata-sidebar): useSidebarMetadataFetcher tests * feat(metadata-sidebar): useSidebarMetadataFetcher tests * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): loading status test * feat(metadata-sidebar): use SidebarContent + tests * feat(metadata-sidebar): template dropdown menu nit fixes --------- Co-authored-by: Karolina Rusek-Bieniek <[email protected]> Co-authored-by: Wiola <[email protected]>
jankowiakdawid
added a commit
to jankowiakdawid/box-ui-elements
that referenced
this pull request
Sep 16, 2024
…3606) * feat(metadata-sidebar): Add AddMetadataTemplateDropdown and improve basic styling * feat(metadata-sidebar): Fix failing tests Extend Jest configuration to not transforming metadata-editor code * feat(metadata-sidebar): add AddMetadataTemplateDropdown To MetadataSidebarRedesign * feat(content-sidebar): Bring back changes to mockServiceWorker.js No idea why they got there in the first place * feat(metadata-sidebar): update storybook * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): simplify storybook * feat(metadata-sidebar): enum status * feat(metadata-sidebar): global variables and enum upper case change * feat(metadata-sidebar): useSidebarMetadataFetcher tests * feat(metadata-sidebar): useSidebarMetadataFetcher tests * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): loading status test * feat(metadata-sidebar): use SidebarContent + tests * feat(metadata-sidebar): template dropdown menu nit fixes --------- Co-authored-by: Karolina Rusek-Bieniek <[email protected]> Co-authored-by: Wiola <[email protected]>
jankowiakdawid
added a commit
to jankowiakdawid/box-ui-elements
that referenced
this pull request
Sep 17, 2024
…3606) * feat(metadata-sidebar): Add AddMetadataTemplateDropdown and improve basic styling * feat(metadata-sidebar): Fix failing tests Extend Jest configuration to not transforming metadata-editor code * feat(metadata-sidebar): add AddMetadataTemplateDropdown To MetadataSidebarRedesign * feat(content-sidebar): Bring back changes to mockServiceWorker.js No idea why they got there in the first place * feat(metadata-sidebar): update storybook * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): simplify storybook * feat(metadata-sidebar): enum status * feat(metadata-sidebar): global variables and enum upper case change * feat(metadata-sidebar): useSidebarMetadataFetcher tests * feat(metadata-sidebar): useSidebarMetadataFetcher tests * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): loading status test * feat(metadata-sidebar): use SidebarContent + tests * feat(metadata-sidebar): template dropdown menu nit fixes --------- Co-authored-by: Karolina Rusek-Bieniek <[email protected]> Co-authored-by: Wiola <[email protected]>
jankowiakdawid
added a commit
that referenced
this pull request
Sep 17, 2024
* feat(metadata-sidebar): Add AddMetadataTemplateDropdown and improve basic styling * feat(metadata-sidebar): Fix failing tests Extend Jest configuration to not transforming metadata-editor code * feat(metadata-sidebar): add AddMetadataTemplateDropdown To MetadataSidebarRedesign * feat(content-sidebar): Bring back changes to mockServiceWorker.js No idea why they got there in the first place * feat(metadata-sidebar): update storybook * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): simplify storybook * feat(metadata-sidebar): enum status * feat(metadata-sidebar): global variables and enum upper case change * feat(metadata-sidebar): useSidebarMetadataFetcher tests * feat(metadata-sidebar): useSidebarMetadataFetcher tests * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): loading status test * feat(metadata-sidebar): use SidebarContent + tests * feat(metadata-sidebar): template dropdown menu nit fixes --------- Co-authored-by: Karolina Rusek-Bieniek <[email protected]> Co-authored-by: Wiola <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Sep 17, 2024
* feat(metadata-sidebar): Add metadata add template dropdown menu (#3606) * feat(metadata-sidebar): Add AddMetadataTemplateDropdown and improve basic styling * feat(metadata-sidebar): Fix failing tests Extend Jest configuration to not transforming metadata-editor code * feat(metadata-sidebar): add AddMetadataTemplateDropdown To MetadataSidebarRedesign * feat(content-sidebar): Bring back changes to mockServiceWorker.js No idea why they got there in the first place * feat(metadata-sidebar): update storybook * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): simplify storybook * feat(metadata-sidebar): enum status * feat(metadata-sidebar): global variables and enum upper case change * feat(metadata-sidebar): useSidebarMetadataFetcher tests * feat(metadata-sidebar): useSidebarMetadataFetcher tests * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): PR comments * feat(metadata-sidebar): loading status test * feat(metadata-sidebar): use SidebarContent + tests * feat(metadata-sidebar): template dropdown menu nit fixes --------- Co-authored-by: Karolina Rusek-Bieniek <[email protected]> Co-authored-by: Wiola <[email protected]> * feat(metadata-sidebar): add metadata empty state to metadata sidebar redesign (#3605) * chore(content-sidebar): Temporarily remove files while we be working with not yet publish internal library. Will remove this commit after the library will become publicly available on NPM and added to BUIE. feat(metadata-sidebar): MetadataEmptyState feat(metadata-sidebar): comment api to pass test feat(metadata-sidebar): uncomment comments feat(metadata-sidebar): add states feat(metadata-sidebar): tests update feat(metadata-sidebar): PR comments feat(metadata-sidebar): delete git add . in showEditor feat(metadata-sidebar): PR comments feat(metadata-sidebar): storybook tests feat(metadata-sidebar): update unit tests feat(metadata-sidebar): pr comments feat(metadata-sidebar): variables name changes feat(metadata-sidebar): PR comments feat(metadata-sidebar): PR comments feat(metadata-sidebar): global token change and status enum feat(metadata-sidebar): global token update feat(metadata-sidebar): global variables and enum upper case change feat(metadata-sidebar): PR comments feat(metadata-sidebar): styles import and title deletion feat(metadata-sidebar): convert type to interface * feat(metadata-sidebar): missing tests after rebase --------- Co-authored-by: Dawid Jankowiak <[email protected]> * feat(metadata-sidebar): Metadata Instance Editor (#3632) * feat(metadata-sidebar): metadata instance editor * feat(metadata-sidebar): modal and tests * feat(metadata-sidebar): isLoading change * feat(metadata-sidebar): change imports * feat(metadata-sidebar): pr comments * feat(metadata-sidebar): Metadata.test.js test fix * feat(metadata-sidebar): modal story additional check * feat(metadata-sidebar): modal open prop * feat(metadata-sidebar): stories * feat(metadata-sidebar): lint comments * feat(metadata-sidebar): stories update * feat(metadata-sidebar): Disable lint for 2 console.logs --------- Co-authored-by: Karolina Rusek-Bieniek <[email protected]> Co-authored-by: Wiola <[email protected]> Co-authored-by: karolinaru <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
AddMetadataTemplateDropdowncomponent. A component that will be adding new templates to metadata sidebar.