Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(content-uploader): migrate upload state #3624

Merged
merged 5 commits into from
Sep 4, 2024
Merged

chore(content-uploader): migrate upload state #3624

merged 5 commits into from
Sep 4, 2024

Conversation

tjiang-box
Copy link
Contributor

  • Converted to typescript
  • Converted old .js to .js.flow
  • Converted to react-testing-library
  • Converted to blueprint component
  • Deleted snapshots

@tjiang-box tjiang-box requested a review from a team as a code owner August 26, 2024 20:29
@box box deleted a comment from tjiang-box Sep 3, 2024
greg-in-a-box
greg-in-a-box previously approved these changes Sep 3, 2024
View reviewed changes
@tjiang-box tjiang-box requested a review from a team as a code owner September 3, 2024 16:35
@tjiang-box tjiang-box requested review from a team as code owners September 3, 2024 18:32
tjuanitas
tjuanitas reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@tjuanitas tjuanitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some nits

bfoxx1906
bfoxx1906 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@bfoxx1906 bfoxx1906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot merged commit 42cc092 into box:master Sep 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjuanitas tjuanitas tjuanitas approved these changes

@bfoxx1906 bfoxx1906 bfoxx1906 approved these changes

@greg-in-a-box greg-in-a-box greg-in-a-box approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tjiang-box @tjuanitas @bfoxx1906 @greg-in-a-box