feat(content-explorer): migrate subheader to pageheader #3903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjiang-box
force-pushed
the
replace-breadcrumb
branch
2 times, most recently
from
935c8aa to
17b872f
Compare
greg-in-a-box
requested changes
Feb 6, 2025
| aria-label={formatMessage(messages.gridViewIncreaseColumnSize)} | ||
| > | ||
| <IconPlusThin color={bdlGray50} width={14} height={14} /> | ||
| </PlainButton> | ||
| </div> | ||
| ) | ||
| ); | ||
| }; | ||
|
|
||
| export { GridViewSlider as GridViewSliderBase }; |
There was a problem hiding this comment.
do we need this still?
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| width: 112px; |
There was a problem hiding this comment.
is there a reason why its set to exactly 112px?
There was a problem hiding this comment.
yeah it is to match what we have in the figma design and the one in webapp
| <IconChevron className="be-breadcrumb-seperator" color={COLOR_999} direction="right" size="7px" /> | ||
| <PointerChevronRight | ||
| className="be-breadcrumb-seperator" | ||
| color={COLOR_999} |
There was a problem hiding this comment.
are we able to replace COLOR_999 with a blueprint token?
| @@ -108,4 +111,4 @@ const Breadcrumbs = ({ rootId, crumbs, onCrumbClick, delimiter, isSmall = false, | |||
| }; | |||
|
|
|||
| export { Breadcrumbs as BreadcrumbsBase }; | |||
| const BreadcrumbDropdown = ({ crumbs, onCrumbClick }: Props) => ( | ||
| <DropdownMenu.Root> | ||
| <DropdownMenu.Trigger> | ||
| <IconButton icon={Ellipsis} /> |
There was a problem hiding this comment.
do we need an aria label here?
tjiang-box
force-pushed
the
replace-breadcrumb
branch
from
17b872f to
35abcab
Compare
greg-in-a-box
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List View including dropdown
Grid View
