Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metadata-sidebar): Beta language #3917

Merged
merged 2 commits into from
Feb 11, 2025
Merged

feat(metadata-sidebar): Beta language #3917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd7a40b
feat(metadata-sidebar): Get and pass isBetaLanguageEnabled
kajarosz Feb 10, 2025
908a553
feat(metadata-sidebar): Get and pass isBetaLanguageEnabled
kajarosz Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
"@box/frontend": "^10.0.0",
"@box/item-icon": "^0.9.58",
"@box/languages": "^1.0.0",
"@box/metadata-editor": "^0.79.1",
"@box/metadata-editor": "^0.88.1",
"@box/react-virtualized": "9.22.3-rc-box.9",
"@cfaester/enzyme-adapter-react-18": "^0.8.0",
"@chromatic-com/storybook": "^1.6.1",
Expand Down Expand Up @@ -310,7 +310,7 @@
"@box/box-ai-content-answers": "^0.86.0",
"@box/cldr-data": ">=34.2.0",
"@box/item-icon": "^0.9.58",
"@box/metadata-editor": "^0.79.1",
"@box/metadata-editor": "^0.88.1",
"@box/react-virtualized": "9.22.3-rc-box.9",
"@hapi/address": "^2.1.4",
"axios": "^0.25.0",
Expand Down
3 changes: 3 additions & 0 deletions src/elements/content-sidebar/MetadataInstanceEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import React from 'react';

export interface MetadataInstanceEditorProps {
areAiSuggestionsAvailable: boolean;
isBetaLanguageEnabled: boolean;
isBoxAiSuggestionsEnabled: boolean;
isDeleteButtonDisabled: boolean;
isUnsavedChangesModalOpen: boolean;
Expand All @@ -31,6 +32,7 @@ export interface MetadataInstanceEditorProps {

const MetadataInstanceEditor: React.FC<MetadataInstanceEditorProps> = ({
areAiSuggestionsAvailable,
isBetaLanguageEnabled,
isBoxAiSuggestionsEnabled,
isDeleteButtonDisabled,
isUnsavedChangesModalOpen,
Expand All @@ -46,6 +48,7 @@ const MetadataInstanceEditor: React.FC<MetadataInstanceEditorProps> = ({
<MetadataInstanceForm
areAiSuggestionsAvailable={areAiSuggestionsAvailable}
isAiSuggestionsFeatureEnabled={isBoxAiSuggestionsEnabled}
isBetaLanguageEnabled={isBetaLanguageEnabled}
isDeleteButtonDisabled={isDeleteButtonDisabled}
isUnsavedChangesModalOpen={isUnsavedChangesModalOpen}
onCancel={onCancel}
Expand Down
3 changes: 3 additions & 0 deletions src/elements/content-sidebar/MetadataSidebarRedesign.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ function MetadataSidebarRedesign({

const { formatMessage } = useIntl();
const isBoxAiSuggestionsEnabled: boolean = useFeatureEnabled('metadata.aiSuggestions.enabled');
const isBetaLanguageEnabled: boolean = useFeatureEnabled('metadata.betaLanguage.enabled');

const [editingTemplate, setEditingTemplate] = React.useState<MetadataTemplateInstance | null>(null);
const [isUnsavedChangesModalOpen, setIsUnsavedChangesModalOpen] = React.useState<boolean>(false);
Expand Down Expand Up @@ -278,6 +279,7 @@ function MetadataSidebarRedesign({
{editingTemplate && (
<MetadataInstanceEditor
areAiSuggestionsAvailable={areAiSuggestionsAvailable}
isBetaLanguageEnabled={isBetaLanguageEnabled}
isBoxAiSuggestionsEnabled={isBoxAiSuggestionsEnabled}
isDeleteButtonDisabled={isDeleteButtonDisabled}
isUnsavedChangesModalOpen={isUnsavedChangesModalOpen}
Expand All @@ -294,6 +296,7 @@ function MetadataSidebarRedesign({
<MetadataInstanceList
areAiSuggestionsAvailable={areAiSuggestionsAvailable}
isAiSuggestionsFeatureEnabled={isBoxAiSuggestionsEnabled}
isBetaLanguageEnabled={isBetaLanguageEnabled}
onEdit={templateInstance => {
setEditingTemplate(templateInstance);
setIsDeleteButtonDisabled(false);
Expand Down
1 change: 1 addition & 0 deletions src/elements/content-sidebar/__tests__/MetadataInstanceEditor.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ describe('MetadataInstanceEditor', () => {

const defaultProps: MetadataInstanceEditorProps = {
areAiSuggestionsAvailable: true,
isBetaLanguageEnabled: false,
isBoxAiSuggestionsEnabled: true,
isDeleteButtonDisabled: false,
isUnsavedChangesModalOpen: false,
Expand Down
6 changes: 2 additions & 4 deletions src/elements/content-sidebar/__tests__/MetadataSidebarRedesign.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,11 +247,9 @@ describe('elements/content-sidebar/Metadata/MetadataSidebarRedesign', () => {

test('should correctly render empty state when AI feature is enabled', () => {
renderComponent({}, { 'metadata.aiSuggestions.enabled': true });
expect(screen.getByRole('heading', { level: 2, name: 'Autofill Metadata with Box AI' })).toBeInTheDocument();
expect(screen.getByRole('heading', { level: 2, name: 'Add Metadata Templates' })).toBeInTheDocument();
expect(
screen.getByText(
'Use the power of Box AI to quickly capture document metadata, with ever-increasing accuracy.',
),
screen.getByText('Add Metadata to your file to support business operations, workflows, and more!'),
).toBeInTheDocument();
});

Expand Down
1 change: 1 addition & 0 deletions src/elements/content-sidebar/stories/MetadataSidebarRedesign.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const mockLogger = {

const defaultMetadataSidebarProps: ComponentProps<typeof MetadataSidebarRedesign> = {
isBoxAiSuggestionsEnabled: true,
isBetaLanguageEnabled: false,
isFeatureEnabled: true,
onError: fn(),
onSuccess: fn(),
Expand Down
7 changes: 7 additions & 0 deletions src/elements/content-sidebar/stories/tests/MetadataSidebarRedesign-visual.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export const AddTemplateDropdownMenuOnEmpty = {
fileId: fileIdWithoutMetadata,
metadataSidebarProps: {
isBoxAiSuggestionsEnabled: true,
isBetaLanguageEnabled: false,
isFeatureEnabled: true,
onError: fn(),
onSuccess: fn(),
Expand Down Expand Up @@ -191,6 +192,7 @@ export const EmptyStateWithBoxAiEnabled: StoryObj<typeof MetadataSidebarRedesign
features: {
...mockFeatures,
'metadata.aiSuggestions.enabled': true,
'metadata.betalanguage.enabled': false,
},
},
};
Expand All @@ -201,6 +203,7 @@ export const EmptyStateWithBoxAiDisabled: StoryObj<typeof MetadataSidebarRedesig
metadataSidebarProps: {
...defaultMetadataSidebarProps,
isBoxAiSuggestionsEnabled: false,
isBetaLanguageEnabled: false,
},
},
};
Expand Down Expand Up @@ -399,6 +402,7 @@ export const MetadataInstanceEditorAIEnabled: StoryObj<typeof MetadataSidebarRed
features: {
...mockFeatures,
'metadata.aiSuggestions.enabled': true,
'metadata.betalanguage.enabled': false,
},
},
play: async ({ canvasElement }) => {
Expand All @@ -420,6 +424,7 @@ export const ShowErrorWhenAIAPIIsUnavailable: StoryObj<typeof MetadataSidebarRed
features: {
...mockFeatures,
'metadata.aiSuggestions.enabled': true,
'metadata.betalanguage.enabled': false,
},
},
parameters: {
Expand Down Expand Up @@ -451,6 +456,7 @@ export const SuggestionsWhenAIAPIResponses: StoryObj<typeof MetadataSidebarRedes
features: {
...mockFeatures,
'metadata.aiSuggestions.enabled': true,
'metadata.betalanguage.enabled': false,
},
},
parameters: {
Expand Down Expand Up @@ -487,6 +493,7 @@ export const SuggestionForNewlyCreatedTemplateInstance: StoryObj<typeof Metadata
features: {
...mockFeatures,
'metadata.aiSuggestions.enabled': true,
'metadata.betalanguage.enabled': false,
},
},
parameters: {
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1528,10 +1528,10 @@
resolved "https://registry.yarnpkg.com/@box/languages/-/languages-1.1.2.tgz#cd4266b3da62da18560d881e10b429653186be29"
integrity sha512-d64TGosx+KRmrLZj4CIyLp42LUiEbgBJ8n8cviMQwTJmfU0g+UwZqLjmQZR1j+Q9D64yV4xHzY9K1t5nInWWeQ==

"@box/metadata-editor@^0.79.1":
version "0.79.1"
resolved "https://registry.yarnpkg.com/@box/metadata-editor/-/metadata-editor-0.79.1.tgz#190a9b245ddda328a5b64f688f2f5818d369ea3e"
integrity sha512-uweWwxfoAlygYPjL0Oght3PQREoqh+vgrpA5mqfHe2o0Q0GetD7+6qyC2cUNS6dPx6hxiKAwkfWneht98zt1yg==
"@box/metadata-editor@^0.88.1":
version "0.88.1"
resolved "https://registry.yarnpkg.com/@box/metadata-editor/-/metadata-editor-0.88.1.tgz#6beedb9e7c73cdd8824f9f52e641ac1ff1899967"
integrity sha512-Q6GXv9B0wSbDh9Uy7tLOg9lMeBiNx3d2WYoEZsf8Jm9kC2w8dWIGbHRqiD3E6GpvomhSrWfHzt2Zy/Bn7BRXDg==

"@box/[email protected]":
version "9.22.3-rc-box.9"
Expand Down