Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tooltip for Age column #1887

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add tooltip for Age column #1887

wants to merge 3 commits into from

Conversation

jlin95
Copy link
Contributor

@jlin95 jlin95 commented Dec 30, 2024

No description provided.

pylipp
pylipp approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@pylipp pylipp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024-12-30-141003_1366x768_scrot

Functional review passes.
@aerinsol added screenshot for you

@pylipp
Copy link
Contributor

pylipp commented Dec 30, 2024 •
edited
Loading

@jlin95 can you try linking this PR from the Trello card via the Github power-up?

nvm, seems the power-up's broken 🙄
https://trello.com/c/ntUENE7L/883-cl20-fe-tooltip-age-for-boxes-explain-that-its-from-box-creation-tiny

@pylipp pylipp requested a review from aerinsol December 30, 2024 13:39
aerinsol
aerinsol requested changes Dec 30, 2024
View reviewed changes
Copy link
Member

@aerinsol aerinsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some sort of info or tappable icon on mobile. Mouseover on header is not sufficient.

@pylipp
Copy link
Contributor

pylipp commented Jan 3, 2025

2025-01-03-115138_1097x275_scrot

@jlin95 I'm afraid the text needs linebreaks or some kind of wrapping because it currently overflows.
@aerinsol any chance we can shorten the text?

@aerinsol
Copy link
Member

aerinsol commented Jan 3, 2025

Still needs an info icon

@pylipp
Copy link
Contributor

pylipp commented Jan 3, 2025

Still needs an info icon

There's an info icon next to the AGE column title, would you like it to be positioned elsewhere?

@jlin95
Copy link
Contributor Author

jlin95 commented Jan 5, 2025

@aerinsol Maybe the other way is to add the disclaimer text above the table when in mobile view? And perhaps shorten the age explanation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerinsol aerinsol aerinsol requested changes

@pylipp pylipp pylipp approved these changes

@fhenrich33 fhenrich33 Awaiting requested review from fhenrich33

@HaGuesto HaGuesto Awaiting requested review from HaGuesto

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlin95 @pylipp @aerinsol