toolexec: Add required-packages flag #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolexec mode only rewrites packages that have import the errtrace package, and others are silently ignored which can lead to unintended missed rewrites. Accept package selectors of packages that must import errtrace if a rewrite is required. Most of this change is setting up the machinery for toolexec flags: - Set up a new flagset for toolexec flags, which are only parsed once we know we're in toolexec mode. - Include a hash of the flag values in the version key as a previously cached output may not be valid when flags change. E.g., a previous package success should fail if the required-packages flag changes and it contains a package that needs a rewrite but is missing the import.
prashantv
force-pushed
the
prashant/toolexec-flags
branch
from
ae4efd5 to
5e269d7
Compare
abhinav
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toolexec mode only rewrites packages that have import the errtrace
package, and others are silently ignored which can lead to unintended
missed rewrites.
Accept package selectors of packages that must import errtrace if a
rewrite is required.
Most of this change is setting up the machinery for toolexec flags:
we know we're in toolexec mode.
cached output may not be valid when flags change. E.g., a previous
package success should fail if the required-packages flag changes and
it contains a package that needs a rewrite but is missing the import.