forked from OCA/server-tools
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing from upstream OCA/server-tools (18.0) #1704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CHG] add name to wml tag to make override easier [FIX] remove domain on active field
OCA Transbot updated translations from Transifex
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-12.0/server-tools-12.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-base_technical_user/
Currently translated at 100.0% (5 of 5 strings) Translation: server-tools-12.0/server-tools-12.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-base_technical_user/pt/
Currently translated at 100.0% (5 of 5 strings) Translation: server-tools-12.0/server-tools-12.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-base_technical_user/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-13.0/server-tools-13.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-13-0/server-tools-13-0-base_technical_user/
Currently translated at 85.7% (6 of 7 strings) Translation: server-tools-14.0/server-tools-14.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_technical_user/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_technical_user/
Currently translated at 54.5% (6 of 11 strings) Translation: server-tools-14.0/server-tools-14.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_technical_user/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_technical_user/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_technical_user/
Currently translated at 100.0% (8 of 8 strings) Translation: server-tools-16.0/server-tools-16.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_technical_user/es/
Currently translated at 100.0% (8 of 8 strings) Translation: server-tools-16.0/server-tools-16.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_technical_user/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-17.0/server-tools-17.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-base_technical_user/
Currently translated at 100.0% (7 of 7 strings) Translation: server-tools-17.0/server-tools-17.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-base_technical_user/zh_CN/
First, the company should be taken through self.env.company as user.company_id is now the default company for the user (and not the current one). Secondly, the actual code does not allow to do recordset.with_company(B).sudo_tech().... as allowed_company_ids in context can be filled in with current company (and not the one of the tech user - which is unique)
When we use use_tech(raise_if_missing=True) and the technical user (user_tech_id) is not defined on the current company, the error message who said that field is empty should be related to the active company and not related to the default user's company.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-base_technical_user/
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 18.0 #1704 +/- ##
==========================================
+ Coverage 72.38% 72.78% +0.40%
==========================================
Files 146 152 +6
Lines 4399 4464 +65
Branches 589 592 +3
==========================================
+ Hits 3184 3249 +65
Misses 1119 1119
Partials 96 96 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bt_gitbot