Depend on napari>=0.5 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=======================================
Coverage 89.66% 89.66%
=======================================
Files 8 8
Lines 484 484
=======================================
Hits 434 434
Misses 50 50 ☔ View full report in Codecov by Sentry. |
|
@alessandrofelder want to bump this to version 0.5? Then feel free to tag me for review so we can merge in. |
willGraham01
approved these changes
Jul 18, 2024
willGraham01
approved these changes
Jul 18, 2024
|
@alessandrofelder I don't qualify as an important enough reviewer it seems 😂 Merging is still blocked because I don't have the necessary permissions for my review to count as enough |
alessandrofelder
force-pushed
the
depend-0.5.0b0
branch
from
9a53e4c to
1cbfe32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
The ultimate goal is to move features from here into core napari.
Now that napari 0.5 is out, this is what we should depend on as a consequence.
We also keep a version of the tests running with
naparimain branch.What does this PR do?
Pin napari version from below to be >=0.5
References
Closes #17
How has this PR been tested?
Usual CI
Is this a breaking change?
We may break compatibility with <0.5 to some extent, but that is intended.
Does this PR require an update to the documentation?
Nope
Checklist: