Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

[WIP]Express #23

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added .rebuild.ts
Empty file.
6 changes: 4 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"main": "dist",
"scripts": {
"start": "NODE_ENV=production NODE_PATH=./packages/hadron-demo/dist npm start --prefix packages/hadron-demo",
"start:test": "NODE_ENV=development NODE_PATH=./packages/hadron-demo ts-node packages/hadron-demo",
"start:dev": "NODE_ENV=development NODE_PATH=./packages/hadron-demo nodemon --watch 'packages/hadron-demo/**/*.ts' --watch .rebuild.ts --ignore 'packages/hadron-demo/**/*.spec.ts' --exec 'ts-node' packages/hadron-demo/index.ts",
"start:lerna": "nodemon --watch 'packages/**/*.ts' --exec 'npm run build && touch .rebuild.ts' -e ts",
"build": "lerna bootstrap",
"prestart": "npm run build",
"precommit": "lint-staged",
Expand All @@ -20,7 +21,8 @@
"docker:build": "docker build -t brainhub-framework-app .",
"format": "prettier --write \"*/**/*.ts\"",
"tsc": "lerna exec tsc --parallel",
"clean": "bash ./scripts/clean"
"clean": "bash ./scripts/clean",
"postinstall": "lerna bootstrap"
},
"author": "Brainhub",
"license": "MIT",
Expand Down
29 changes: 17 additions & 12 deletions packages/hadron-core/src/hadronCore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,27 @@ export const prepareConfig = (
};

export default (
server: any,
packages: any[] = [],
config: any = {},
): Promise<IContainer> => {
container.register('server', server);

const logger = createLogger({ name: 'hadron-logger' });
container.register('hadronLogger', logger);

return prepareConfig(hadronDefaultConfig, config, logger).then(
(hadronConfig) => {
return Promise.all(
packages
.filter(({ register }) => !!register)
.map(({ register }) => register(container, hadronConfig)),
).then(() => container);
},
);
return prepareConfig(hadronDefaultConfig, config, logger)
.then((hadronConfig) => {
const registers = packages
.filter(({ register }) => !!register)
.map(({ register }) => register);

let p = Promise.resolve();

registers.forEach((register) => {
p = p.then(() => {
register(container, hadronConfig);
});
});

return p;
})
.then(() => container);
};
18 changes: 5 additions & 13 deletions packages/hadron-demo/index.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import * as bodyParser from 'body-parser';
import * as express from 'express';
import hadron, { IContainer } from '@brainhubeu/hadron-core';
import * as hadronEvents from '@brainhubeu/hadron-events';
import * as hadronSerialization from '@brainhubeu/hadron-serialization';
import * as hadronExpress from '@brainhubeu/hadron-express';
import * as hadronLogger from '@brainhubeu/hadron-logger';
import * as hadronTypeORM from '@brainhubeu/hadron-typeorm';
import jsonProvider from '@brainhubeu/hadron-json-provider';
import expressConfig from './express-demo';
Expand All @@ -15,10 +12,6 @@ import serializationRoutes from './serialization/routing';
import { setupSerializer } from './serialization/serialization-demo';
import 'reflect-metadata';

const port = process.env.PORT || 8080;
const expressApp = express();
expressApp.use(bodyParser.json());

jsonProvider(['./routing/*'], ['js']).then((routes: any) => {
const config = {
...typeormConfig,
Expand All @@ -32,16 +25,15 @@ jsonProvider(['./routing/*'], ['js']).then((routes: any) => {
};

hadron(
expressApp,
[hadronEvents, hadronSerialization, hadronExpress, hadronTypeORM],
[hadronExpress, hadronEvents, hadronSerialization, hadronTypeORM],
config,
).then((container: IContainer) => {
expressApp.use((req, res, next) =>
res.status(404).json('Request not found.'),
);
container
.take('server')
.use((req: any, res: any) => res.status(404).json('Request not found.'));
container.register('customValue', 'From Brainhub with ❤️');
setupSerializer();
expressApp.listen(port);
container.take('serverListen')();
});

return;
Expand Down
18 changes: 16 additions & 2 deletions packages/hadron-express/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
import hadronExpress from './src/hadronToExpress';
import * as express from 'express';
import * as bodyParser from 'body-parser';

export {
Callback,
IRoutesConfig,
Expand All @@ -16,11 +19,22 @@ import {

export default hadronExpress;

export const register = (container: IContainer, config: IHadronExpressConfig) =>
hadronExpress(
export const register = (
container: IContainer,
config: IHadronExpressConfig,
) => {
const port = process.env.PORT || 8080;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make a possibility to change the default port in the config object.

const expressApp = express();
expressApp.use(bodyParser.json());
container.register('server', expressApp);
container.register('serverListen', () => {
expressApp.listen(port);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be executed maybe after all packages would load (maybe using hadron-events package) or there could be an option in config's objects to disable auto-executing listen method and do it manually - with that option there should be a possibility to provide more custom parameters (https://expressjs.com/en/api.html#app.listen).

});
return hadronExpress(
{
routes: config.routes as IRoutesConfig,
routePaths: config.routePaths as RoutePathsConfig,
},
container,
);
};
1 change: 1 addition & 0 deletions packages/hadron-express/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export type RoutePathsConfig = string[][];
export interface IContainer {
take: (key: string) => any;
keys: () => string[];
register: (key: string, value: any) => any;
}

export interface IHeaders {
Expand Down