This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
[WIP]Express #23
Open
drymek
wants to merge
7
commits into
brainhubeu:master
Choose a base branch
from
drymek:express
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP]Express #23
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3eeab1d
Autoreload nodemon during development
041b517
Merge branch 'master' of https://github.com/brainhubeu/hadron into de…
0911d5a
Remove express as a hard dependency
2b42edc
Lerna bootstrap as post install
156de5b
Lerna bootstrap instead of additional package
c94ce9d
Merge branch 'development' of github.com:drymek/hadron into express
7f234b0
Naming convention
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
import hadronExpress from './src/hadronToExpress'; | ||
import * as express from 'express'; | ||
import * as bodyParser from 'body-parser'; | ||
|
||
export { | ||
Callback, | ||
IRoutesConfig, | ||
|
@@ -16,11 +19,22 @@ import { | |
|
||
export default hadronExpress; | ||
|
||
export const register = (container: IContainer, config: IHadronExpressConfig) => | ||
hadronExpress( | ||
export const register = ( | ||
container: IContainer, | ||
config: IHadronExpressConfig, | ||
) => { | ||
const port = process.env.PORT || 8080; | ||
const expressApp = express(); | ||
expressApp.use(bodyParser.json()); | ||
container.register('server', expressApp); | ||
container.register('serverListen', () => { | ||
expressApp.listen(port); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This could be executed maybe after all packages would load (maybe using hadron-events package) or there could be an option in config's objects to disable auto-executing listen method and do it manually - with that option there should be a possibility to provide more custom parameters (https://expressjs.com/en/api.html#app.listen). |
||
}); | ||
return hadronExpress( | ||
{ | ||
routes: config.routes as IRoutesConfig, | ||
routePaths: config.routePaths as RoutePathsConfig, | ||
}, | ||
container, | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make a possibility to change the default port in the config object.