Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNIRF]] Fix data importation #760

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

Edouard2laire
Copy link
Contributor

Improve snirf file reading. This is a smaller version of #756 for easier review

  • Read file where timeOffset is not defined in the aux structure
  • Fix the channel names when using custom name (replace Tx with S and Rx with D)

@Edouard2laire
Copy link
Contributor Author

@rcassani, we are hosting a workshop at Concordia next week. Do you think you could merge this PR before Thursday as it is needed to load the dataset we want to show to the participants?

Thanks a lot :)

@rcassani rcassani merged commit 0c2e6f4 into brainstorm-tools:master Feb 1, 2025
@rcassani
Copy link
Member

rcassani commented Feb 1, 2025

@Edouard2laire , done
FYI @tmedani

@tmedani
Copy link
Member

tmedani commented Feb 2, 2025

Thanks @rcassani
@Edouard2laire, it will be great to add it to the list of the courses in the website,
and we can post announcement on the LinkedIn as well

@Edouard2laire
Copy link
Contributor Author

Thanks a lot.

You can find all the information about the workshop here: https://www.artinis.com/nirs-introduction-course-ca

@Edouard2laire Edouard2laire deleted the snirf-fix branch February 2, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants