Moving the validation logic

braintree · Dec 12, 2023 · 5f524a7 · 5f524a7
1 parent 4cef02a
commit 5f524a7
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 9 deletions.
diff --git a/BraintreeCore/src/main/java/com/braintreepayments/api/ShopperInsightsClient.kt b/BraintreeCore/src/main/java/com/braintreepayments/api/ShopperInsightsClient.kt
@@ -23,6 +23,18 @@ class ShopperInsightsClient @VisibleForTesting internal constructor(
         request: ShopperInsightsRequest,
         callback: ShopperInsightsCallback
     ) {
+        if (request.email == null && request.phone == null) {
+            callback.onResult(
+                ShopperInsightsResult.Failure(
+                    IllegalArgumentException(
+                        "One of ShopperInsightsRequest.email or " +
+                            "ShopperInsightsRequest.phone must be non-null."
+                    )
+                )
+            )
+            return
+        }
+
         // TODO: - Add isAppInstalled checks for PP & Venmo. DTBTSDK-3176
         paymentReadyAPI.processRequest(request)
         // Hardcoded result

diff --git a/BraintreeCore/src/main/java/com/braintreepayments/api/ShopperInsightsRequest.kt b/BraintreeCore/src/main/java/com/braintreepayments/api/ShopperInsightsRequest.kt
@@ -6,12 +6,6 @@ package com.braintreepayments.api
  * Note: **This feature is in beta. It's public API may change in future releases.**
  */
 data class ShopperInsightsRequest(
-    val email: String?,
-    val phone: BuyerPhone?
-) {
-    init {
-        require(email != null || phone != null) {
-            "Both email and phone cannot be null."
-        }
-    }
-}
+    var email: String?,
+    var phone: BuyerPhone?
+)
diff --git a/BraintreeCore/src/test/java/com/braintreepayments/api/ShopperInsightsClientUnitTest.kt b/BraintreeCore/src/test/java/com/braintreepayments/api/ShopperInsightsClientUnitTest.kt
@@ -1,6 +1,7 @@
 package com.braintreepayments.api
 
 import io.mockk.mockk
+import kotlin.test.assertEquals
 import kotlin.test.assertIs
 import org.junit.Assert.assertNotNull
 import org.junit.Before
@@ -38,4 +39,19 @@ class ShopperInsightsClientUnitTest {
             assertNotNull(successResult.response.isVenmoRecommended)
         }
     }
+
+    @Test
+    fun `testGetRecommendedPaymentMethods - request object has null properties`() {
+        val request = ShopperInsightsRequest(null, null)
+        sut.getRecommendedPaymentMethods(request) { result ->
+            assertNotNull(result)
+            val error = assertIs<ShopperInsightsResult.Failure>(result)
+            val iae = assertIs<IllegalArgumentException>(error.error)
+            assertEquals(
+                "One of ShopperInsightsRequest.email or " +
+                    "ShopperInsightsRequest.phone must be non-null.",
+                iae.message
+            )
+        }
+    }
 }