Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PayPal Result Object Refactor #836

Merged
merged 11 commits into from
Dec 4, 2023
Merged

PayPal Result Object Refactor #836

merged 11 commits into from
Dec 4, 2023

Conversation

sarahkoop
Copy link
Contributor

Summary of changes

  • Update PayPal public API to return single result objects in callbacks from createPaymentAuthRequest and tokenize
  • Internal methods still return (result, error) params - to be updated in future PR.

Checklist

  • Added a changelog entry

Authors

@sarahkoop sarahkoop requested a review from a team as a code owner November 30, 2023 20:22
@sarahkoop sarahkoop merged commit 5573448 into v5 Dec 4, 2023
2 checks passed
@sarahkoop sarahkoop deleted the paypal_single_result_object branch December 4, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshropshire sshropshire sshropshire approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahkoop @jaxdesmarais @sshropshire