-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card Single Result Object #841
Conversation
@@ -86,6 +86,8 @@ | |||
* Card | |||
* Remove `threeDSecureInfo` from `CardNonce` | |||
* Move `ThreeDSecureInfo` to `three-d-secure` module | |||
* Add `CardResult` object | |||
* Change `CardTokenizeCallback` parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we feel like it'd be helpful to merchants to know what the change is to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are pretty much changing the parameters of every public method and callback throughout the SDK for this version, I've just been saying "change parameters" to keep the CHANGELOG less verbose. The detailed changes are in the migration guide though. So I don't know because yes it might be helpful to see the actual parameter changes, but also for every method that is changing the CHANGELOG will get very long and verbose. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to leave the generic parameters CHANGELOG notes for now but will reconsider how detailed we are for all of the changes in the CHANGELOG before the first beta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think we were pretty verbose in the iOS changelog, it's quite long for the betas. No idea if it's helpful or not though.
Summary of changes
CardResult
object. This aligns with result handling across all payment method modules. See v5 Result Object Proposal #813 for more background on this refactor.Checklist
Authors