Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECS5 App Switch Feature Bug Fixes #1512

Open
wants to merge 2 commits into
base: app-switch-checkout-feature
Choose a base branch
from
Open

ECS5 App Switch Feature Bug Fixes #1512

wants to merge 2 commits into from
+5 −3

Conversation

agedd
Copy link
Contributor

@agedd agedd commented Feb 4, 2025

Summary of changes

  • Re-added the token parameter and added logic to pass that into the launchPayPalApp() function
  • Fixed parsing logic to read the launchPayPalApp boolean value from GW to determine the redirectType

Checklist

  • [ ] Added a changelog entry
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

@agedd agedd requested a review from a team as a code owner February 4, 2025 17:54
@warmkesselj
Copy link
Contributor

Looks like this unit test is failing: testTokenizeVaultAccount_whenPayPalAppApprovalURLPresent_attemptsAppSwitchWithParameters

jaxdesmarais
jaxdesmarais reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the failing test Justin mentioned, can we verify that there is a test for: ba_token present, token present, and error if neither exists. We may already have these cases covered but just wanted to make sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaxdesmarais jaxdesmarais jaxdesmarais left review comments

@scannillo scannillo scannillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agedd @warmkesselj @jaxdesmarais @scannillo