Extracts component styles as Tailwind plugins #18

AlanBreck · 2022-08-11T21:32:11Z

No description provided.

fallaciousreasoning

This looks pretty good to me (and I'm stoked that we'll be able to use Tailwind!).

socket-security · 2023-07-14T21:45:55Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
postcss-sort-media-queries	4.2.1	None	`+1`	34.1 kB	yunusga

github-actions · 2023-07-14T21:51:46Z

src/tokens/transformation/tailwind/extractComponentStyles.js

+          const cssAsJs = postcssJs.objectify(root)
+
+          return writeFile(
+            join(config.buildPath, 'plugins', `${fileParts.name}Component.js`),


_{reported by reviewdog 🐶}
[semgrep] Detected possible user input going into a path.join or path.resolve function. This could possibly lead to a path traversal vulnerability, where the attacker can access arbitrary files stored in the file system. Instead, be sure to sanitize or validate user input first.

Source: https://semgrep.dev/r/javascript.lang.security.audit.path-traversal.path-join-resolve-traversal.path-join-resolve-traversal

Cc @thypon @bcaller

fallaciousreasoning · 2023-07-18T00:05:42Z

Looks like format is failing - running npm run format should fix it 😄

github-actions · 2023-07-26T22:33:23Z

src/tokens/transformation/tailwind/convertCssToJs.js

@@ -5,6 +5,9 @@ const postcss = require('postcss')

 const cssFiles = ['variables.css']

+const genPluginFilePath = (file, config) =>
+  join(config.buildPath, 'plugins', `_${file}.ts`)


_{reported by reviewdog 🐶}
[semgrep] Detected possible user input going into a path.join or path.resolve function. This could possibly lead to a path traversal vulnerability, where the attacker can access arbitrary files stored in the file system. Instead, be sure to sanitize or validate user input first.

Source: https://semgrep.dev/r/javascript.lang.security.audit.path-traversal.path-join-resolve-traversal.path-join-resolve-traversal

Cc @thypon @bcaller

src/tokens/transformation/tailwind/extractComponentStyles.js

src/tokens/transformation/tailwind/copyStaticFiles.js

github-actions · 2023-08-23T21:38:49Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://18.pr.leo.bravesoftware.com/
✅ Commit preview: https://18.pr.leo.bravesoftware.com/commit-f9ddb6526ea6ed62f1d62a7cd1ba9f958dcbca6f/

Variables Diff

--- ./tokens/css/variables.old.css	2023-08-23 21:36:39.246926648 +0000
+++ ./tokens/css/variables.css	2023-08-23 21:35:55.610908822 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 23 2023 19:58:56 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 23 2023 21:35:55 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Co-authored-by: Jay Harris <[email protected]>

github-actions · 2023-08-29T23:30:06Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://18.pr.leo.bravesoftware.com/
✅ Commit preview: https://18.pr.leo.bravesoftware.com/commit-bde3e4e6cc1017cae9966603ab766e801f5bf024/

Variables Diff

--- ./tokens/css/variables.old.css	2023-08-29 23:28:04.867956166 +0000
+++ ./tokens/css/variables.css	2023-08-29 23:27:24.829616830 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Aug 29 2023 22:01:19 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Aug 29 2023 23:27:24 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

github-actions · 2023-08-29T23:33:18Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://18.pr.leo.bravesoftware.com/
✅ Commit preview: https://18.pr.leo.bravesoftware.com/commit-dafdfd6fb5655990ba1847520493661b40395562/

Variables Diff

--- ./tokens/css/variables.old.css	2023-08-29 23:31:33.441230125 +0000
+++ ./tokens/css/variables.css	2023-08-29 23:31:01.025096186 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Aug 29 2023 22:01:19 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Aug 29 2023 23:31:01 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

fallaciousreasoning · 2023-08-30T00:18:17Z

Does this fix #4?

AlanBreck · 2023-09-06T16:11:06Z

Does this fix #4?

It sounds like it might, but I'm not certain.

github-actions · 2023-09-07T18:26:17Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://18.pr.leo.bravesoftware.com/
✅ Commit preview: https://18.pr.leo.bravesoftware.com/commit-7f43ebde2521341a258eaf40ec3e5c671efb10a0/

Variables Diff

--- ./tokens/css/variables.old.css	2023-09-07 18:24:26.083004949 +0000
+++ ./tokens/css/variables.css	2023-09-07 18:23:51.138332856 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Sep 06 2023 21:27:54 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Sep 07 2023 18:23:51 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

github-actions · 2023-09-07T18:30:55Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://18.pr.leo.bravesoftware.com/
✅ Commit preview: https://18.pr.leo.bravesoftware.com/commit-98e60f0e0bd0d0cd9a71810a642b5e27bf8d1e13/

Variables Diff

--- ./tokens/css/variables.old.css	2023-09-07 18:28:27.170340742 +0000
+++ ./tokens/css/variables.css	2023-09-07 18:27:38.742108830 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Sep 06 2023 21:27:54 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Sep 07 2023 18:27:38 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

fallaciousreasoning

LGTM

github-actions · 2023-09-28T21:48:55Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://18.pr.nala.bravesoftware.com/
✅ Commit preview: https://18.pr.nala.bravesoftware.com/commit-fbe77c8c17f3a0cb6a8858d02f9252c83447fb5b/

Variables Diff

--- ./tokens/css/variables.old.css	2023-09-28 21:46:51.510420868 +0000
+++ ./tokens/css/variables.css	2023-09-28 21:46:10.385932891 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Sep 28 2023 21:25:54 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Sep 28 2023 21:46:10 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

AlanBreck requested a review from petemill August 11, 2022 21:32

AlanBreck changed the title ~~WIP: extracts component styles as Tailwind plugins~~ Extracts component styles as Tailwind plugins Aug 24, 2022

AlanBreck force-pushed the extract-component-styles branch from 037efce to 4b918af Compare August 24, 2022 18:53

AlanBreck mentioned this pull request Sep 8, 2022

Add plugin for extracting component CSS to a separate file #28

Closed

fallaciousreasoning reviewed Sep 12, 2022

View reviewed changes

AlanBreck force-pushed the extract-component-styles branch from 4b918af to f8d2b3d Compare July 14, 2023 21:38

AlanBreck had a problem deploying to staging July 14, 2023 21:38 — with GitHub Actions Failure

github-actions bot added the needs-security-review label Jul 14, 2023

github-actions bot assigned bcaller and thypon Jul 14, 2023

AlanBreck force-pushed the extract-component-styles branch from f8d2b3d to 8c42e1a Compare July 14, 2023 21:44

AlanBreck had a problem deploying to staging July 14, 2023 21:44 — with GitHub Actions Failure

AlanBreck force-pushed the extract-component-styles branch from 8c42e1a to b4e5ca1 Compare July 14, 2023 21:49

AlanBreck had a problem deploying to staging July 14, 2023 21:49 — with GitHub Actions Failure

github-actions bot reviewed Jul 14, 2023

View reviewed changes

AlanBreck force-pushed the extract-component-styles branch from b4e5ca1 to 60450ea Compare July 26, 2023 22:30

AlanBreck had a problem deploying to staging July 26, 2023 22:30 — with GitHub Actions Failure

github-actions bot reviewed Jul 26, 2023

View reviewed changes

fallaciousreasoning reviewed Jul 27, 2023

View reviewed changes

src/tokens/transformation/tailwind/extractComponentStyles.js Outdated Show resolved Hide resolved

fallaciousreasoning reviewed Jul 27, 2023

View reviewed changes

src/tokens/transformation/tailwind/copyStaticFiles.js Show resolved Hide resolved

AlanBreck had a problem deploying to staging July 28, 2023 20:20 — with GitHub Actions Failure

AlanBreck force-pushed the extract-component-styles branch from 8a79230 to f74fb10 Compare August 23, 2023 21:33

AlanBreck had a problem deploying to staging August 23, 2023 21:33 — with GitHub Actions Failure

AlanBreck temporarily deployed to staging August 23, 2023 21:34 — with GitHub Actions Inactive

AlanBreck had a problem deploying to staging August 29, 2023 22:22 — with GitHub Actions Failure

AlanBreck force-pushed the extract-component-styles branch from 050bec3 to a2924c2 Compare August 29, 2023 22:24

AlanBreck temporarily deployed to staging August 29, 2023 22:24 — with GitHub Actions Inactive

AlanBreck added 7 commits August 29, 2023 16:26

extracts styles from svelte components as Tailwind plugins

595edb8

WIP: fixes component style extraction for tailwind

7664fe9

removes elevation tokens from tailwind/variables.css

d8ef04a

updates tailwind transformation for new tokens

5708159

removes hack to avoid conflicts with anchor styles and .leoButton

328b26c

fixes formatting

94f5394

refactors 'getAllFiles' to use 'walk'

bde3e4e

AlanBreck force-pushed the extract-component-styles branch from a2924c2 to bde3e4e Compare August 29, 2023 23:26

AlanBreck temporarily deployed to staging August 29, 2023 23:26 — with GitHub Actions Inactive

Update package.json

dafdfd6

Co-authored-by: Jay Harris <[email protected]>

AlanBreck temporarily deployed to staging August 29, 2023 23:30 — with GitHub Actions Inactive

AlanBreck added 2 commits September 7, 2023 14:20

addresses PR feedback

96c5135

fixes shadow behavior for light/dark and dropShadows

8da9804

AlanBreck had a problem deploying to staging September 7, 2023 18:20 — with GitHub Actions Failure

AlanBreck temporarily deployed to staging September 7, 2023 18:22 — with GitHub Actions Inactive

AlanBreck force-pushed the extract-component-styles branch from 7f43ebd to 98e60f0 Compare September 7, 2023 18:23

AlanBreck temporarily deployed to staging September 7, 2023 18:26 — with GitHub Actions Inactive

fallaciousreasoning approved these changes Sep 14, 2023

View reviewed changes

format code

fbe77c8

AlanBreck force-pushed the extract-component-styles branch from 98e60f0 to fbe77c8 Compare September 28, 2023 21:45

AlanBreck temporarily deployed to staging September 28, 2023 21:45 — with GitHub Actions Inactive

AlanBreck merged commit 74ac237 into main Sep 28, 2023

AlanBreck deleted the extract-component-styles branch September 28, 2023 21:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extracts component styles as Tailwind plugins #18

Extracts component styles as Tailwind plugins #18

AlanBreck commented Aug 11, 2022

fallaciousreasoning left a comment

socket-security bot commented Jul 14, 2023 •

edited

Loading

github-actions bot Jul 14, 2023

fallaciousreasoning commented Jul 18, 2023

github-actions bot Jul 26, 2023

github-actions bot commented Aug 23, 2023

github-actions bot commented Aug 29, 2023

github-actions bot commented Aug 29, 2023

fallaciousreasoning commented Aug 30, 2023

AlanBreck commented Sep 6, 2023

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

fallaciousreasoning left a comment

github-actions bot commented Sep 28, 2023

Extracts component styles as Tailwind plugins #18

Extracts component styles as Tailwind plugins #18

Conversation

AlanBreck commented Aug 11, 2022

fallaciousreasoning left a comment

Choose a reason for hiding this comment

socket-security bot commented Jul 14, 2023 • edited Loading

github-actions bot Jul 14, 2023

Choose a reason for hiding this comment

fallaciousreasoning commented Jul 18, 2023

github-actions bot Jul 26, 2023

Choose a reason for hiding this comment

github-actions bot commented Aug 23, 2023

github-actions bot commented Aug 29, 2023

github-actions bot commented Aug 29, 2023

fallaciousreasoning commented Aug 30, 2023

AlanBreck commented Sep 6, 2023

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

fallaciousreasoning left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 28, 2023

socket-security bot commented Jul 14, 2023 •

edited

Loading