Improves linting for project #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a couple places minor code changes were also made so as to adhere to new linting rules. Tests have been conducted and transparency.json is confirmed to have maintain its shape.
jonathansampson
added
the
dependencies
AlanBreck
reviewed
Aug 13, 2024
| @@ -25,7 +23,7 @@ export async function getCreatorGrowth() { | |||
| /** | |||
| * Make sure records are in chronological order so that | |||
| * when we iterate, the most recent data is always last. | |||
| */ | |||
| * */ | |||
There was a problem hiding this comment.
I may not be reading this carefully enough, but the changes in this file seem to be beyond linting, as it modifies the flow (by moving code within the if (trades.length > 0) condition).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a couple places minor code changes were also made so as to adhere to new linting rules. Tests have been conducted and transparency.json is confirmed to have maintain its shape.